Build creates invalid jars

[snjeza]

I have tried to build bazel-vscode-java in the following way:

$ git clone git@github.com:eclipseguru/bazel-eclipse.git
$ git clone git@github.com:salesforce/bazel-vscode-java.git
$ cd bazel-vscode-java
$ npm run build

There are two issues:

1. The build succeeds, but creates invalid jars.

$ jar tvf server/com.github.ben-manes.caffeine.jar 
java.util.zip.ZipException: zip END header not found
	at java.base/java.util.zip.ZipFile$Source.findEND(ZipFile.java:1637)
	at java.base/java.util.zip.ZipFile$Source.initCEN(ZipFile.java:1645)
	at java.base/java.util.zip.ZipFile$Source.<init>(ZipFile.java:1483)
	at java.base/java.util.zip.ZipFile$Source.get(ZipFile.java:1445)
	at java.base/java.util.zip.ZipFile$CleanableResource.<init>(ZipFile.java:717)
	at java.base/java.util.zip.ZipFile.<init>(ZipFile.java:251)
	at java.base/java.util.zip.ZipFile.<init>(ZipFile.java:180)
	at java.base/java.util.zip.ZipFile.<init>(ZipFile.java:151)
	at jdk.jartool/sun.tools.jar.Main.list(Main.java:1503)
	at jdk.jartool/sun.tools.jar.Main.run(Main.java:368)
	at jdk.jartool/sun.tools.jar.Main.main(Main.java:1681)

2. com.salesforce.bazel.sdk requires org.apache.velocity.engine-core.

[guw]

Ouch. I wonder if this is a gulp problem?

bazel-vscode-java/gulpfile.js

Lines 151 to 157 in fbeb0a8

	gulp
	.src(
	BAZEL_ECLIPSE_DIR + '/releng/p2repository/target/repository/plugins/*.jar'
	)
	.pipe(DROP_JAR_VERSION)
	.pipe(jarIsIncludedInPackageJson)
	.pipe(gulp.dest('./server'));

[snjeza]

#144 fixes both issues.