Skip to content

Also emit "Dyn Compatibility" section for traits that *are* dyn compatible#156835

Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
yotamofek:pr/positive-dyn-compatible
May 22, 2026
Merged

Also emit "Dyn Compatibility" section for traits that *are* dyn compatible#156835
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
yotamofek:pr/positive-dyn-compatible

Conversation

@yotamofek
Copy link
Copy Markdown
Contributor

I was using the std docs to check if a trait was dyn compatible, and was very confused that it had no info about dyn compatibility. I had to go look at a trait that I knew for certain was not dyn compatible (Clone) to verify that we still had the dyn compatibility section, and that its omission meant a trait was compatible.

(also removed the "..., so this trait is not object safe" text because it seemed pretty redundant)

r? @fmease

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output. labels May 22, 2026
Copy link
Copy Markdown
Member

@fmease fmease left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors Bot commented May 22, 2026

📌 Commit 877d57c has been approved by fmease

It is now in the queue for this repository.

🌲 The tree is currently closed for pull requests below priority 10. This pull request will be tested once the tree is reopened.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 22, 2026
@rust-bors

This comment has been minimized.

@rust-bors rust-bors Bot added merged-by-bors This PR was explicitly merged by bors. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 22, 2026
@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors Bot commented May 22, 2026

☀️ Test successful - CI
Approved by: fmease
Duration: 3h 17m 14s
Pushing 54333ff to main...

@rust-bors rust-bors Bot merged commit 54333ff into rust-lang:main May 22, 2026
12 checks passed
@rustbot rustbot added this to the 1.98.0 milestone May 22, 2026
@github-actions
Copy link
Copy Markdown
Contributor

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing b52edc2 (parent) -> 54333ff (this PR)

Test differences

Show 2 test diffs

2 doctest diffs were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 54333ff079780f803f65dcee30c544050b35f544 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. x86_64-msvc-2: 2h 35m -> 1h 36m (-37.9%)
  2. optional-x86_64-gnu-parallel-frontend: 2h 30m -> 1h 34m (-37.4%)
  3. i686-msvc-1: 2h 18m -> 3h 1m (+31.4%)
  4. x86_64-gnu-llvm-21-1: 40m 21s -> 50m 51s (+26.0%)
  5. dist-x86_64-apple: 2h 2m -> 1h 45m (-14.0%)
  6. i686-gnu-nopt-1: 2h 20m -> 2h 2m (-12.5%)
  7. dist-sparcv9-solaris: 1h 15m -> 1h 6m (-12.5%)
  8. aarch64-apple: 3h 1m -> 2h 39m (-12.2%)
  9. x86_64-msvc-1: 2h 30m -> 2h 47m (+11.6%)
  10. x86_64-msvc-ext1: 2h 10m -> 2h 22m (+9.8%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer
Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (54333ff): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This perf run didn't have relevant results for this metric.

Max RSS (memory usage)

Results (primary 0.4%, secondary -2.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
10.1% [10.1%, 10.1%] 1
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-2.8% [-3.5%, -2.2%] 3
Improvements ✅
(secondary)
-2.0% [-2.4%, -1.4%] 3
All ❌✅ (primary) 0.4% [-3.5%, 10.1%] 4

Cycles

Results (primary 3.8%, secondary -3.5%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
3.8% [3.8%, 3.8%] 1
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-3.5% [-4.3%, -2.9%] 3
All ❌✅ (primary) 3.8% [3.8%, 3.8%] 1

Binary size

Results (primary 0.1%, secondary 0.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
0.1% [0.0%, 0.1%] 50
Regressions ❌
(secondary)
0.1% [0.0%, 0.1%] 24
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 0.1% [0.0%, 0.1%] 50

Bootstrap: 513.181s -> 510.282s (-0.56%)
Artifact size: 400.52 MiB -> 400.55 MiB (0.01%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merged-by-bors This PR was explicitly merged by bors. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants