Rollup of 3 pull requests by JonathanBrouwer · Pull Request #156773 · rust-lang/rust

JonathanBrouwer · 2026-05-20T13:37:33Z

Successful merges:

Reorg tests 04 #156317 (Reorg tests 04)
Add an example to the NumBuffer documentations #156747 (Add an example to the NumBuffer documentations)
delegation: visit qself under elided-infer lifetime rib #156766 (delegation: visit qself under elided-infer lifetime rib)

We specifically call out that the sign is written for negative integers. This would also ideally be called out in `<iN>::format_into`, but the macro infrastructure for the implementation unfortunately doesn't really make this easy as far as I can tell.

…r=GuillaumeGomez Add an example to the `NumBuffer` documentations We specifically call out that the sign is written for negative integers. This would also ideally be called out in `<iN>::format_into`, but the macro infrastructure for the implementation unfortunately doesn't really make this easy as far as I can tell. Ref rust-lang#138215

@petrochenkov

…t-rib, r=petrochenkov delegation: visit qself under elided-infer lifetime rib Follow-up for rust-lang#156705, we need to visit delegation's qself under elided-infer lifetime rib too. Fixes rust-lang#156758. Part of rust-lang#118212. r? @petrochenkov

JonathanBrouwer · 2026-05-20T13:37:50Z

@bors r+ rollup=never p=5

rust-bors · 2026-05-20T13:37:53Z

📌 Commit b332bfa has been approved by JonathanBrouwer

It is now in the queue for this repository.

…uwer Rollup of 3 pull requests Successful merges: - #156317 (Reorg tests 04) - #156747 (Add an example to the `NumBuffer` documentations) - #156766 (delegation: visit qself under elided-infer lifetime rib)

rust-log-analyzer · 2026-05-20T15:57:53Z

The job dist-android failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

[TIMING:end] builder::Libdir { compiler: Compiler { stage: 0, host: x86_64-unknown-linux-gnu, forced_compiler: false }, target: x86_64-unknown-linux-gnu } -- 0.000
[TIMING:end] compile::StdLink { compiler: Compiler { stage: 0, host: x86_64-unknown-linux-gnu, forced_compiler: false }, target_compiler: Compiler { stage: 0, host: x86_64-unknown-linux-gnu, forced_compiler: false }, target: x86_64-unknown-linux-gnu, crates: [], force_recompile: false } -- 0.002
##[group]Building stage1 compiler artifacts (stage0 -> stage1, x86_64-unknown-linux-gnu)
    Updating crates.io index
error: failed to get `leb128fmt` as a dependency of package `wast v246.0.2`
    ... which satisfies dependency `wast = "^246.0.2"` (locked to 246.0.2) of package `wat v1.246.2`
    ... which satisfies dependency `wat = "^1.246.2"` (locked to 1.246.2) of package `wasm-component-ld v0.5.22`
    ... which satisfies dependency `wasm-component-ld = "^0.5.22"` (locked to 0.5.22) of package `wasm-component-ld-wrapper v0.1.0 (/checkout/src/tools/wasm-component-ld)`

Caused by:
  failed to load source for dependency `leb128fmt`

Caused by:
  unable to update registry `crates-io`

Caused by:
  download of le/b1/leb128fmt failed

Caused by:
  curl failed

Caused by:

rust-bors · 2026-05-20T15:59:04Z

💔 Test for 1cf887f failed: CI. Failed job:

auto - dist-android (web logs, enhanced plaintext logs)

JonathanBrouwer · 2026-05-20T16:38:21Z

@bors retry

rust-bors · 2026-05-20T23:22:18Z

☀️ Test successful - CI
Approved by: JonathanBrouwer
Duration: 3h 19m 21s
Pushing b954122 to main...

rust-timer · 2026-05-20T23:23:13Z

📌 Perf builds for each rolled up PR:

PR#	Message	Perf Build Sha
#156317	Reorg tests 04	`b3846c2ea8ed5d506a5547f98831140f5add6c9a` (link)
#156747	Add an example to the `NumBuffer` documentations	`88b54c821903bb747ae2af8f76ba0a736fed503d` (link)
#156766	delegation: visit qself under elided-infer lifetime rib	`49c4c07bcc13b9daf213dd1878ecc7385bcd13ff` (link)

previous master: 9128490ab3

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

github-actions · 2026-05-20T23:25:43Z

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 9128490 (parent) -> b954122 (this PR)

Test differences

Show 34 test diffs

Stage 1

[ui] tests/ui/associated-types/sized-recursive-type-via-associated-type.rs: [missing] -> pass (J0)
[ui] tests/ui/codegen/correctly-monomorphize-generic-drop-impl.rs: [missing] -> pass (J0)
[ui] tests/ui/codegen/dont-roundup-dst-prefix-size-to-alignment.rs: [missing] -> pass (J0)
[ui] tests/ui/consts/size_of-requires-type-annotation-in-const.rs: [missing] -> pass (J0)
[ui] tests/ui/delegation/wrong-lifetime-rib-ice-156342.rs: pass -> [missing] (J0)
[ui] tests/ui/delegation/wrong-lifetime-rib.rs: [missing] -> pass (J0)
[ui] tests/ui/issues/issue-27997.rs: pass -> [missing] (J0)
[ui] tests/ui/issues/issue-31299.rs: pass -> [missing] (J0)
[ui] tests/ui/issues/issue-35815.rs: pass -> [missing] (J0)
[ui] tests/ui/issues/issue-46855.rs: pass -> [missing] (J0)
[ui] tests/ui/issues/issue-47486.rs: pass -> [missing] (J0)
[ui] tests/ui/issues/issue-50811.rs: pass -> [missing] (J0)
[ui] tests/ui/mir/dont-use-operand-as-place-for-zst.rs: [missing] -> pass (J0)
[ui] tests/ui/mir/validate-various-comparison-behavior.rs: [missing] -> pass (J0)

Stage 2

[ui] tests/ui/associated-types/sized-recursive-type-via-associated-type.rs: [missing] -> pass (J1)
[ui] tests/ui/codegen/correctly-monomorphize-generic-drop-impl.rs: [missing] -> pass (J1)
[ui] tests/ui/codegen/dont-roundup-dst-prefix-size-to-alignment.rs: [missing] -> pass (J1)
[ui] tests/ui/consts/size_of-requires-type-annotation-in-const.rs: [missing] -> pass (J1)
[ui] tests/ui/delegation/wrong-lifetime-rib-ice-156342.rs: pass -> [missing] (J1)
[ui] tests/ui/delegation/wrong-lifetime-rib.rs: [missing] -> pass (J1)
[ui] tests/ui/issues/issue-27997.rs: pass -> [missing] (J1)
[ui] tests/ui/issues/issue-31299.rs: pass -> [missing] (J1)
[ui] tests/ui/issues/issue-35815.rs: pass -> [missing] (J1)
[ui] tests/ui/issues/issue-46855.rs: pass -> [missing] (J1)
[ui] tests/ui/issues/issue-47486.rs: pass -> [missing] (J1)
[ui] tests/ui/issues/issue-50811.rs: pass -> [missing] (J1)
[ui] tests/ui/mir/dont-use-operand-as-place-for-zst.rs: [missing] -> pass (J1)
[ui] tests/ui/mir/validate-various-comparison-behavior.rs: [missing] -> pass (J1)

Additionally, 6 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard b954122bbe6c4a244c511a9a168c6d5438d8f58f --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

dist-arm-linux-musl: 2h 37m -> 1h 40m (-35.7%)
dist-arm-linux-gnueabi: 1h 49m -> 1h 12m (-34.2%)
x86_64-msvc-2: 2h -> 2h 40m (+33.5%)
dist-armv7-linux: 1h 50m -> 1h 14m (-32.1%)
dist-sparcv9-solaris: 2h 18m -> 1h 33m (-32.0%)
dist-x86_64-solaris: 2h 19m -> 1h 36m (-30.3%)
x86_64-gnu-gcc: 1h 11m -> 51m 56s (-27.5%)
dist-x86_64-musl: 3h 2m -> 2h 14m (-26.3%)
dist-android: 36m 21s -> 27m 44s (-23.7%)
x86_64-mingw-1: 2h 57m -> 2h 19m (-21.5%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

rust-timer · 2026-05-21T00:04:05Z

Finished benchmarking commit (b954122): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.1%	[-0.1%, -0.1%]	1
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results (secondary -1.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.2%	[2.2%, 2.2%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.7%	[-2.8%, -2.6%]	2
All ❌✅ (primary)	-	-	0

Cycles

Results (primary 2.1%, secondary -3.2%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	2.1%	[2.1%, 2.2%]	2
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-3.2%	[-5.2%, -1.8%]	7
All ❌✅ (primary)	2.1%	[2.1%, 2.2%]	2

Binary size

This perf run didn't have relevant results for this metric.

Bootstrap: 517.203s -> 514.377s (-0.55%)
Artifact size: 400.60 MiB -> 400.61 MiB (0.00%)

lokirithm and others added 7 commits May 13, 2026 01:15

Move test files from issues/ to appropriate subdirectories

ee5f63f

Update files

664af69

Visit delegation's qself under elided-infer lifetime rib too

b75c532

rust-bors Bot added the rollup A PR which is a rollup label May 20, 2026

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels May 20, 2026

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 20, 2026

This comment has been minimized.

Sign in to view

rust-bors Bot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 20, 2026

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 20, 2026

This comment has been minimized.

Sign in to view

rust-bors Bot added merged-by-bors This PR was explicitly merged by bors. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 20, 2026

rust-bors Bot merged commit b954122 into rust-lang:main May 20, 2026
12 checks passed

rustbot added this to the 1.97.0 milestone May 20, 2026

rust-bors Bot mentioned this pull request May 20, 2026

Stabilize int_format_into feature #152544

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Rollup of 3 pull requests#156773

Rollup of 3 pull requests#156773
rust-bors[bot] merged 7 commits into
rust-lang:mainfrom
JonathanBrouwer:rollup-C3CCRv2

JonathanBrouwer commented May 20, 2026

Uh oh!

JonathanBrouwer commented May 20, 2026

Uh oh!

rust-bors Bot commented May 20, 2026

Uh oh!

This comment has been minimized.

rust-log-analyzer commented May 20, 2026

Uh oh!

rust-bors Bot commented May 20, 2026

Uh oh!

JonathanBrouwer commented May 20, 2026

Uh oh!

This comment has been minimized.

rust-bors Bot commented May 20, 2026

Uh oh!

Uh oh!

rust-timer commented May 20, 2026

Uh oh!

github-actions Bot commented May 20, 2026

Stage 1

Stage 2

Uh oh!

rust-timer commented May 21, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Uh oh!

Conversation

JonathanBrouwer commented May 20, 2026

Uh oh!

JonathanBrouwer commented May 20, 2026

Uh oh!

rust-bors Bot commented May 20, 2026

Uh oh!

This comment has been minimized.

rust-log-analyzer commented May 20, 2026

Uh oh!

rust-bors Bot commented May 20, 2026

Uh oh!

JonathanBrouwer commented May 20, 2026

Uh oh!

This comment has been minimized.

rust-bors Bot commented May 20, 2026

Uh oh!

Uh oh!

rust-timer commented May 20, 2026

Uh oh!

github-actions Bot commented May 20, 2026

Test differences

Stage 1

Stage 2

Job duration changes

Uh oh!

rust-timer commented May 21, 2026

Overall result: ✅ improvements - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants