Skip to content

Turn elided_lifetimes_in_associated_constant FCW into a hard error#156508

Draft
oli-obk wants to merge 1 commit into
rust-lang:mainfrom
oli-obk:boom
Draft

Turn elided_lifetimes_in_associated_constant FCW into a hard error#156508
oli-obk wants to merge 1 commit into
rust-lang:mainfrom
oli-obk:boom

Conversation

@oli-obk
Copy link
Copy Markdown
Contributor

@oli-obk oli-obk commented May 12, 2026 •
edited by rustbot
Loading

fixes #115010

This FCW has been on for almost a year, let's turn it into a hard error. Doing a crater run before nominating

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels May 12, 2026
@oli-obk
Copy link
Copy Markdown
Contributor Author

oli-obk commented May 12, 2026

@bors try

@rust-bors

This comment has been minimized.

Sign in to view
rust-bors Bot pushed a commit that referenced this pull request May 12, 2026
@bors
Auto merge of #156508 - oli-obk:boom, r=<try>
b28cc4e 
Turn elided_lifetimes_in_associated_constant FCW into a hard error
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors Bot commented May 12, 2026

☀️ Try build successful (CI)
Build commit: b28cc4e (b28cc4eb48a6415b914e8ad0308be255ff8d73ed, parent: 2aabf3ce0569dd7c8c2d2a27944850056dcf2566)

@oli-obk
Copy link
Copy Markdown
Contributor Author

oli-obk commented May 13, 2026

@craterbot check

@craterbot
Copy link
Copy Markdown
Collaborator

craterbot commented May 13, 2026

👌 Experiment pr-156508 created and queued.
🤖 Automatically detected try build b28cc4e
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-crater Status: Waiting on a crater run to be completed. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 13, 2026
@rustbot rustbot added the T-rust-analyzer Relevant to the rust-analyzer team, which will review and decide on the PR/issue. label May 13, 2026
@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors Bot commented May 13, 2026

☔ The latest upstream changes (presumably #138995) made this pull request unmergeable. Please resolve the merge conflicts.

@craterbot
Copy link
Copy Markdown
Collaborator

craterbot commented May 21, 2026

🚧 Experiment pr-156508 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot
Copy link
Copy Markdown
Collaborator

craterbot commented May 23, 2026

🎉 Experiment pr-156508 is completed!
📊 3 regressed and 10 fixed (931813 total)
📊 5201 spurious results on the retry-regressed-list.txt, consider a retry1 if this is a significant amount.
📰 Open the summary report.

⚠️ If you notice any spurious failure please add them to the denylist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

Footnotes

  1. re-run the experiment with crates=https://crater-reports.s3.amazonaws.com/pr-156508/retry-regressed-list.txt ↩

@craterbot craterbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-crater Status: Waiting on a crater run to be completed. labels May 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rust-analyzer Relevant to the rust-analyzer team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Tracking issue for future-incompatibility lint elided_lifetimes_in_associated_constant

4 participants

@oli-obk @rust-log-analyzer @craterbot @rustbot