Skip to content

Cleanups attributes in tests#17050

Open
samueltardieu wants to merge 2 commits into
rust-lang:masterfrom
samueltardieu:cleanups/attributes-in-tests
Open

Cleanups attributes in tests#17050
samueltardieu wants to merge 2 commits into
rust-lang:masterfrom
samueltardieu:cleanups/attributes-in-tests

Conversation

@samueltardieu
Copy link
Copy Markdown
Member

Cleanup existing tests:

  • remove unneeeded attributes (such as #![allow(unused)])
  • use expect instead of allow when possible (in the absence of a .fixed file, or if the lint still triggers in the .fixed file, and remove unnecessary allow attributes

changelog: none

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label May 21, 2026
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented May 21, 2026

r? @Jarcho

rustbot has assigned @Jarcho.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: 7 candidates
  • 7 candidates expanded to 7 candidates
  • Random selection from Jarcho, llogiq

@samueltardieu samueltardieu changed the title Cleanups/attributes in tests Cleanups attributes in tests May 21, 2026
@samueltardieu samueltardieu force-pushed the cleanups/attributes-in-tests branch from b34c6cb to a63909a Compare May 21, 2026 21:05
@samueltardieu
Copy link
Copy Markdown
Member Author

Since we talked about this yesterday at the AllHands:
r? ada4a

@rustbot rustbot assigned ada4a and unassigned Jarcho May 22, 2026
@rustbot

This comment has been minimized.

@samueltardieu samueltardieu force-pushed the cleanups/attributes-in-tests branch from a63909a to f51b2ed Compare May 23, 2026 08:54
@rustbot

This comment has been minimized.

@samueltardieu samueltardieu force-pushed the cleanups/attributes-in-tests branch from f51b2ed to 8b1396b Compare May 23, 2026 09:57
@rustbot

This comment has been minimized.

@samueltardieu samueltardieu force-pushed the cleanups/attributes-in-tests branch from 8b1396b to 6a5bcbb Compare May 24, 2026 01:16
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented May 24, 2026

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants