Do not trigger integer_division_remainder_used in macros#17049
Open
samueltardieu wants to merge 1 commit into
Open
Do not trigger integer_division_remainder_used in macros#17049samueltardieu wants to merge 1 commit into
integer_division_remainder_used in macros#17049samueltardieu wants to merge 1 commit into
Conversation
rustbot
added
the
S-waiting-on-review
Collaborator
|
r? @llogiq rustbot has assigned @llogiq. Use Why was this reviewer chosen?The reviewer was selected based on:
|
|
Lintcheck changes for 474a100
This comment will be updated if you push new changes |
Contributor
|
Shouldn't this only not trigger in external macros? |
samueltardieu
force-pushed
the
issues/17048
branch
from
5c7f665 to
474a100
Compare
Member
Author
Yes, since this is a restriction it is better not to have false negatives indeed. Updated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
changelog: [
integer_division_remainder_used]: do not trigger in macrosFixes #17048