New by_ref_peekable_peek lint#17042
Open
samueltardieu wants to merge 1 commit into
Open
Conversation
rustbot
added
needs-fcp
Collaborator
|
r? @Jarcho rustbot has assigned @Jarcho. Use Why was this reviewer chosen?The reviewer was selected based on:
|
samueltardieu
force-pushed
the
lints/by_ref_peekable_peek
branch
from
274ead3 to
bad070b
Compare
Jarcho
requested changes
May 21, 2026
| use super::BY_REF_PEEKABLE_PEEK; | ||
|
|
||
| pub(super) fn check(cx: &LateContext<'_>, expr: &Expr<'_>, recv: &Expr<'_>) { | ||
| if let Some(recvs) = method_chain_args(recv, &[sym::by_ref, sym::peekable]) |
Contributor
There was a problem hiding this comment.
Can we not use method_chain_args. It's only mildly shorter to write, but it's notably slower and does a hidden from_expansion check on everything.
Comment on lines
+12
to
+16
| && cx | ||
| .typeck_results() | ||
| .expr_ty(recv) | ||
| .peel_refs() | ||
| .is_diag_item(cx, sym::IterPeekable) |
Contributor
There was a problem hiding this comment.
This doesn't check that we called the correct peekable function.
Comment on lines
+19
to
+20
| && let Some(def_id) = cx.typeck_results().type_dependent_def_id(recvs[1].0.hir_id) | ||
| && paths::ITERATOR_BY_REF.matches(cx, def_id) |
Contributor
There was a problem hiding this comment.
cx.ty_based_def(recvs[1].0).opt_parent().is_diag_item(sym::Iterator)
rustbot
added
S-waiting-on-author
Contributor
|
@rustbot label lint-nominated |
Collaborator
|
This lint has been nominated for inclusion. |
rustbot
added
the
S-waiting-on-review
samueltardieu
force-pushed
the
lints/by_ref_peekable_peek
branch
from
bad070b to
1eb259c
Compare
Member
Author
|
I've changed the code to not use |
rustbot
removed
the
S-waiting-on-author
samueltardieu
force-pushed
the
lints/by_ref_peekable_peek
branch
from
1eb259c to
c6e0832
Compare
samueltardieu
force-pushed
the
lints/by_ref_peekable_peek
branch
from
c6e0832 to
59f63dd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
changelog: [
by_ref_peekable_peek]: new lintCloses #17020