Added identity_assign_op lint#17038
Open
JaafarTanoukhi wants to merge 2 commits into
Open
Conversation
rustbot
added
needs-fcp
Collaborator
|
r? @llogiq rustbot has assigned @llogiq. Use Why was this reviewer chosen?The reviewer was selected based on:
|
samueltardieu
requested changes
May 20, 2026
Member
There was a problem hiding this comment.
There are a few problems with this proposed implementation:
- Ignoring the statement means removing it, not just replacing it with the LHS expression.
- Why is there a TODO in the source?
- User types may implement those operators, and they might not be removable because they can contain side effects.
- Floating points types are ignored.
- Even if the snippet cannot be retrieved, the lint is currently marked
MachineApplicablewhich is not true. - Tests involving macros should be added.
@rustbot author
rustbot
added
S-waiting-on-author
Collaborator
|
Reminder, once the PR becomes ready for a review, use |
Contributor
|
In the original issue there was a suggestion to focus on that this may be a bug, rather than that it can be simplified. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
changelog: [
identity_assign_op]: new lintfixes #16977