Add new try_from_instead_of_from_str lint#17030
Open
GuillaumeGomez wants to merge 1 commit into
Open
Conversation
rustbot
added
needs-fcp
Collaborator
|
r? @Jarcho rustbot has assigned @Jarcho. Use Why was this reviewer chosen?The reviewer was selected based on:
|
|
Lintcheck changes for 196b173
This comment will be updated if you push new changes |
GuillaumeGomez
force-pushed
the
try_from_instead_of_from_str
branch
3 times, most recently
from
c67930d to
02a96bd
Compare
GuillaumeGomez
force-pushed
the
try_from_instead_of_from_str
branch
from
02a96bd to
196b173
Compare
Jarcho
requested changes
May 21, 2026
Contributor
There was a problem hiding this comment.
You also have to check if the error type is using the lifetime since FromStr can't capture there either. Also please make sure to put the HIR matching code before item identification code. It's generally faster to check since it doesn't got through the query system.
Comment on lines
+56
to
+71
| let ItemKind::Impl(imp) = item.kind else { return }; | ||
| let Some(of_trait) = imp.of_trait else { return }; | ||
| let Some(trait_def_id) = of_trait.trait_ref.trait_def_id() else { | ||
| return; | ||
| }; | ||
| if !cx.tcx.is_diagnostic_item(sym::TryFrom, trait_def_id) { | ||
| return; | ||
| } | ||
|
|
||
| let impl_def_id = item.owner_id.to_def_id(); | ||
| let trait_ref = cx.tcx.impl_trait_ref(impl_def_id); | ||
|
|
||
| let instantiated_trait_ref = trait_ref.instantiate_identity().skip_norm_wip(); | ||
|
|
||
| if let Some(from_arg) = instantiated_trait_ref.args.get(1) | ||
| && let Some(from_ty) = from_arg.as_type() |
Contributor
There was a problem hiding this comment.
Pleas just put all these in the same if let chain.
Comment on lines
+79
to
+87
| for assoc_item in imp.items { | ||
| match cx.tcx.hir_expect_impl_item(assoc_item.owner_id.def_id).kind { | ||
| ImplItemKind::Type(ty) => err_ty = snippet_opt(cx, ty.span), | ||
| ImplItemKind::Fn(_, body_id) => { | ||
| fn_body = snippet_opt(cx, cx.tcx.hir_span_with_body(body_id.hir_id)); | ||
| }, | ||
| ImplItemKind::Const(..) => {}, | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
This shouldn't be a loop. There are always exactly two items when implementing TryFrom
rustbot
added
S-waiting-on-author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #14522.
One big thing: I'm not sure if the lint name is good, so very much up to debate.
changelog: Add new
try_from_instead_of_from_strlint