Skip to content

docs: update --fix target selection documentation#17027

Open
leno23 wants to merge 1 commit into
rust-lang:masterfrom
leno23:fix/docs-clippy-fix-target-selection-15433
Open

docs: update --fix target selection documentation#17027
leno23 wants to merge 1 commit into
rust-lang:masterfrom
leno23:fix/docs-clippy-fix-target-selection-15433

Conversation

@leno23
Copy link
Copy Markdown

@leno23 leno23 commented May 17, 2026

Fixes #15433

Made with Cursor

Fixes rust-lang#15433

Co-authored-by: Cursor <cursoragent@cursor.com>
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label May 17, 2026
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented May 17, 2026

r? @samueltardieu

rustbot has assigned @samueltardieu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: 7 candidates
  • 7 candidates expanded to 7 candidates
  • Random selection from Jarcho, llogiq, samueltardieu

@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented May 17, 2026

⚠️ Warning ⚠️

  • There are issue links (such as #123) in the commit messages of the following commits.
    Please move them to the PR description, to avoid spamming the issues with references to the commit, and so this bot can automatically canonicalize them to avoid issues with subtree.

Copy link
Copy Markdown
Member

@samueltardieu samueltardieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The proper fix is to remove the notes, not to modify them.

Please also remove issue number in commit message (but let it be in the PR description). Please also remove advertising for the tool you used in the PR description.

View changes since this review

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties labels May 17, 2026
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented May 17, 2026

Reminder, once the PR becomes ready for a review, use @rustbot ready.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Documentation still says that --fix selects all targets, even though the behavior was changed

3 participants