types v25 `GetBlockStats` fields are optional but not and `Option<>`

[jamillambert]

As the title says.

Noticed reviewing another PR, possibly other types with the same issue.

[Abeeujah]

@jamillambert the fields of GetBlockStats were made optional from v23 this issue states, fix types v25, do I adhere strictly to fixing the implementation of v25, or fix from v23?

[jamillambert]

The implementations for all versions should match what is returned by the RPC. i.e. if they are optional in v23 then yes they should be changed to Option in v23 types, and then all later versions redefinitions too.

Thanks for looking into it.

[Abeeujah]

possibly other types with the same issue.

I didn't link #534 to close this issue because of this, is there an order preferred to have these types audited and fix any deviation from core?

[jamillambert]

One of the problems which makes auditing difficult is that the Core docs are not always correct, highlighted by #534. A good way to check would be to use Core's test cases #58. But in terms of order of preference no not really.