This repository was archived by the owner on Apr 18, 2026. It is now read-only.
fix(agent): close critical API gaps for repo split (milestone-0)#185
Merged
Conversation
- F1: re-export Logger and LogManager from soliplex_agent barrel so consumers don't need a direct soliplex_logging dependency - F2: make llmProvider optional in AgentRuntime, defaulting to AgUiLlmProvider wired from the ServerConnection - F8: bridge AG-UI BaseEvents into lastExecutionEvent signal via RunOrchestrator.baseEvents stream so consumers see TextDelta, ThinkingStarted, ServerToolCallStarted, RunCompleted, etc. - fix(agent): change AgentApi.cancelAgent return from bool to void and stop evicting the handle prematurely so getResult works after cancel - chore: remove redundant soliplex_logging imports from tests, apply dart format Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Add trailing commas to typedef parameters and record literals that dart format was collapsing onto single lines, causing the linter to flag missing commas under --fatal-infos in CI. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…l changes - agent_plugin: return null explicitly from cancelAgent handler now that the method returns void - soliplex_tui: remove redundant soliplex_logging import (now re-exported from soliplex_agent barrel) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
LoggerandLogManagerfromsoliplex_agentbarrel — consumers no longer need a directsoliplex_loggingdependencyllmProvideroptional inAgentRuntime, defaulting toAgUiLlmProviderwired from theServerConnection— hides the REST/SSE split from consumersBaseEvents intolastExecutionEventsignal viaRunOrchestrator.baseEventsstream —TextDelta,ThinkingStarted,ServerToolCallStarted,RunCompletedetc. now emit without pollingRunStateAgentApi.cancelAgentreturn frombooltovoid, fix premature handle eviction sogetResultworks after cancelAll changes are backward-compatible. No breaking changes.
Test plan
dart test --exclude-tags integration)dart formatcleandart analyze --fatal-infos— only pre-existingrequire_trailing_commasremain🤖 Generated with Claude Code