build: 3.0.3

Author: CarlosCarmona

.eslintrc.json

@@ -18,6 +18,16 @@
     "indent": ["error", 2, { "SwitchCase": 1 }],
     "default-case": "error",
     "linebreak-style": ["error", "unix"],
-    "semi": ["error", "always"]
+    "semi": ["error", "always"],
+    "no-console": "error",
+    "no-undef": "error",
+    "no-var": "error",
+    "no-caller": "error",
+    "no-throw-literal": "error",
+    "no-unneeded-ternary": "error",
+    "prefer-const": "error",
+    "comma-spacing": ["error", { "before": false, "after": true }],
+    "comma-style": ["error", "last"],
+    "handle-callback-err": ["error", "^(err|error)$"]
   }
 }

.prettierignore

@@ -1,11 +1,10 @@
 node_modules
-.all-contributorsrc
 .eslintignore
 .gitignore
 .prettierignore
-.DS_Store
+.npmignore
 LICENSE
 *.png
 *.txt
 TODO
-*.md
+.DS_Store

README.md

@@ -7,12 +7,13 @@
 
 [![NPM version][npm-image]][npm-url] [![Downloads][downloads-image]][npm-url] [![Dependency Status][david-badge]][david-badge-url]
 <a href="#badge">
-  <img alt="code style: prettier" src="https://img.shields.io/badge/code_style-prettier-ff69b4.svg">
+<img alt="code style: prettier" src="https://img.shields.io/badge/code_style-prettier-ff69b4.svg">
 </a>
 
 # Executor for [Runnerty]: HTTP
 
 ### Installation:
+
 Through NPM
 
 ```bash
@@ -34,7 +35,9 @@ rty add @runnerty/executor-http
 ```
 
 ### Configuration sample:
+
 Add in [config.json]:
+
 ```json
 {
   "id": "http_default",
@@ -43,24 +46,26 @@ Add in [config.json]:
 ```
 
 ### Plan sample:
+
 Add in [plan.json]:
+
 ```json
 {
   "id": "http_default",
-  "headers": {"User-Agent": "runnerty"},
+  "headers": { "User-Agent": "runnerty" },
   "method": "get",
   "url": "https://api.github.com/search/repositories",
-  "params":{"q": "runnerty"},
+  "params": { "q": "runnerty" },
   "responseType": "json"
 }
 ```
 
 ```json
 {
   "id": "http_default",
-  "headers": {"User-Agent": "runnerty"},
+  "headers": { "User-Agent": "runnerty" },
   "url": "http://www.sample.com/form",
-  "method":"post",
+  "method": "post",
   "data": {
     "key1": "value1",
     "key2": "value2"
@@ -76,8 +81,10 @@ Add in [plan.json]:
   "headers": { "User-Agent": "runnerty" },
   "url": "http://www.sample.com/uploadfile",
   "method": "post",
-  "files":[{"name":"fileOne", "path":"/var/myfile.txt"},
-           {"name":"fileTwo", "path":"/var/www/runnerty.jpg"}],
+  "files": [
+    { "name": "fileOne", "path": "/var/myfile.txt" },
+    { "name": "fileTwo", "path": "/var/www/runnerty.jpg" }
+  ],
   "responseType": "json",
   "returnHeaderDataOutput": true
 }
@@ -98,8 +105,10 @@ Add in [plan.json]:
 ```
 
 ### Pagination:
+
 It is possible to make calls to APIs that return `JSON` data that requires paging.
 The parameters available for paging are:
+
 ```
 start                           - page from which the query is initiated, by default 1
 limit                           - maximum elements per page
@@ -113,7 +122,9 @@ token.data_param_name           - name of the parameter to be sent in the body w
 token.next_token_from_response  - params path of the response data from which to get the next page token
 token.next_token_from_header    - params path of the header data from which to get the next page token
 ```
+
 Some paginations examples:
+
 ```json
 {
   "id": "http_default",
@@ -128,6 +139,7 @@ Some paginations examples:
   "noReturnDataOutput": true
 }
 ```
+
 ```json
 {
   "id": "http_default",
@@ -142,6 +154,7 @@ Some paginations examples:
   "noReturnDataOutput": true
 }
 ```
+
 ```json
 {
   "id": "http_default",
@@ -161,9 +174,11 @@ Some paginations examples:
 ```
 
 ### Output (Process values):
-* `PROCESS_EXEC_DATA_OUTPUT`: Response output data.
-It is possible to return the header response in dataoutput by activating the `returnHeaderDataOutput (boolean)` parameter
-* `EXTRA_DATA`: If the response is a `JSON` it is possible to work with the parsed values of the response using the `"responseType": "json"` parameter. If we receive for example:
+
+- `PROCESS_EXEC_DATA_OUTPUT`: Response output data.
+  It is possible to return the header response in dataoutput by activating the `returnHeaderDataOutput (boolean)` parameter
+- `EXTRA_DATA`: If the response is a `JSON` it is possible to work with the parsed values of the response using the `"responseType": "json"` parameter. If we receive for example:
+
 ```json
 {
   "planet": {
@@ -179,10 +194,11 @@ It is possible to return the header response in dataoutput by activating the `re
   }
 }
 ```
+
 It is possible to access the values by ([GETVALUE] function):
 `PROCESS_EXEC_PLANET_NAME`: "Mars", `PROCESS_EXEC_PLANET_NAME_SATELLITES_1_NAME`:"phobos"
 
-* `PROCESS_EXEC_ERR_OUTPUT`: Error output message.
+- `PROCESS_EXEC_ERR_OUTPUT`: Error output message.
 
 ### Other considerations
 
@@ -199,13 +215,13 @@ If the result is very large, you should consider using the "noReturnDataOutput"
 }
 ```
 
-[Runnerty]: http://www.runnerty.io
+[runnerty]: http://www.runnerty.io
 [downloads-image]: https://img.shields.io/npm/dm/@runnerty/executor-http.svg
 [npm-url]: https://www.npmjs.com/package/@runnerty/executor-http
 [npm-image]: https://img.shields.io/npm/v/@runnerty/executor-http.svg
 [david-badge]: https://david-dm.org/runnerty/executor-http.svg
 [david-badge-url]: https://david-dm.org/runnerty/executor-http
-[GETVALUE]: http://docs.runnerty.io/functions/
+[getvalue]: http://docs.runnerty.io/functions/
 [config.json]: http://docs.runnerty.io/config/
 [plan.json]: http://docs.runnerty.io/plan/
-[runnerty-cli]: https://www.npmjs.com/package/runnerty-cli
+[runnerty-cli]: https://www.npmjs.com/package/runnerty-cli

index.js

@@ -84,7 +84,7 @@ class httpExecutor extends Executor {
     // FILES FORM
     if (values.files && (values.method === 'post' || values.method === 'put')) {
       const form = new formData();
-      let filesLength = values.files.length;
+      const filesLength = values.files.length;
       for (let i = 0; i < filesLength; i++) {
         form.append(values.files[i].name, fs.createReadStream(values.files[i].path));
       }
@@ -236,6 +236,7 @@ class httpExecutor extends Executor {
               resolve();
             })
             .on('error', err => {
+              writeStream.end();
               throw err;
             });
         } else {
@@ -251,7 +252,6 @@ class httpExecutor extends Executor {
         this.endOptions.messageLog = err.message;
         this.endOptions.err_output = err.message;
         this.endOptions.end = 'error';
-        writeStream.end();
         this.end(this.endOptions);
         resolve();
       }