Updates for runZero 5.0#47
Draft
hdm wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refactors every integration script to use the new Starlark API surface from platform #25553. Result: ~1,800 lines added, ~2,000 lines removed across 60 files.
Changes
to_custom_attributes(...).custom-integration-/custom_integration_/custom-integrations-filename prefix. Each directory now contains a<name>.star(e.g. tailscale.star, cisco-ise.star, boilerplate.star).snipe-it/snipeit.star(pre-refactor copy).kubectl create serviceaccount+viewClusterRole +kubectl create token.INSECURE_SKIP_VERIFYwasn't being threaded through tooauth2_token/get_json).no-{id,mac,ip,name}-{match,break}tokens with three recommendedmatch_behaviorpresets (default, "stable identifiers but unstable name/mac/ip", "always create new").<integration-name>.starnaming convention.Validation
Pre-merge validator (
go run /tmp/parse_integrations/main.goagainst the platform'sValidateStarlarkProgram): 39 files checked, 0 failures.