Skip to content
This repository was archived by the owner on Apr 14, 2021. It is now read-only.

Commit 4da3289

Browse files
Merge #7508
7508: Release 2.1.2 r=deivid-rodriguez a=deivid-rodriguez ### What was the end-user problem that led to this PR? The problem was that I want to ship [a small regression fix](#7505), and also so tweaks to the development environment (#7506) that I want to use in the rubygems side to fix the CI errors in ruby/rubygems#3043. ### What is your fix for the problem, implemented in this PR? My fix is to release 2.1.2 Co-authored-by: Bundlerbot <bot@bundler.io> Co-authored-by: David Rodríguez <deivid.rodriguez@riseup.net>
2 parents 8bd21aa + 010e79b commit 4da3289

File tree

7 files changed

+27
-22
lines changed

7 files changed

+27
-22
lines changed

.travis.yml

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,17 @@ script: bin/rake spec:travis
44
before_script:
55
- travis_retry gem install rake:"~> 12.0"
66
- travis_retry bin/rake override_version
7-
- travis_retry bin/rake spec:travis:deps
7+
- travis_retry bin/rake spec:deps
88
- bin/rake man:check
9+
- if [ "$BUNDLER_SPEC_SUB_VERSION" = "" ];
10+
then
11+
travis_retry sudo apt-get install graphviz -y;
12+
fi
13+
- if [ "$TRAVIS_RUBY_VERSION" = "2.3.8" ];
14+
then
15+
sudo sed -i 's/1000::/1000:Travis:/g' /etc/passwd;
16+
sudo sed -i '/secure_path/d' /etc/sudoers;
17+
fi
918

1019
branches:
1120
only:

CHANGELOG.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,9 @@
1+
## 2.1.2 (December 20, 2019)
2+
3+
Bugfixes:
4+
5+
- Restore an explicit `require "rubygems"` on top `rubygems_integration.rb` to avoid some missing constant errors under some convoluted setups [#7505](https://github.com/bundler/bundler/pull/7505)
6+
17
## 2.1.1 (December 17, 2019)
28

39
Bugfixes:

Rakefile

Lines changed: 1 addition & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -36,24 +36,6 @@ namespace :spec do
3636
Spec::Rubygems.dev_setup
3737
end
3838

39-
namespace :travis do
40-
task :deps do
41-
# Give the travis user a name so that git won't fatally error
42-
system "sudo sed -i 's/1000::/1000:Travis:/g' /etc/passwd"
43-
# Strip secure_path so that RVM paths transmit through sudo -E
44-
system "sudo sed -i '/secure_path/d' /etc/sudoers"
45-
# Refresh packages index that the ones we need can be installed
46-
sh "sudo apt-get update"
47-
# Install groff so ronn can generate man/help pages
48-
sh "sudo apt-get install groff-base=1.22.3-10 -y"
49-
# Install graphviz so that the viz specs can run
50-
sh "sudo apt-get install graphviz -y"
51-
52-
# Install the other gem deps, etc
53-
Rake::Task["spec:deps"].invoke
54-
end
55-
end
56-
5739
task :clean do
5840
rm_rf "tmp"
5941
end
@@ -127,7 +109,7 @@ task :check_rvm_integration do
127109
# The rubygems-bundler gem is installed by RVM by default and it could easily
128110
# break when we change bundler. Make sure that binstubs still run with it
129111
# installed.
130-
sh("bin/rake install && gem install rubygems-bundler && rake -T")
112+
sh("gem install rubygems-bundler && RUBYOPT=-Ilib rake -T")
131113
end
132114

133115
namespace :man do

lib/bundler/rubygems_integration.rb

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
# frozen_string_literal: true
22

3+
require "rubygems"
4+
35
module Bundler
46
class RubygemsIntegration
57
if defined?(Gem::Ext::Builder::CHDIR_MONITOR)

lib/bundler/version.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
# frozen_string_literal: false
22

33
module Bundler
4-
VERSION = "2.1.1".freeze
4+
VERSION = "2.1.2".freeze
55

66
def self.bundler_major_version
77
@bundler_major_version ||= VERSION.split(".").first.to_i

spec/runtime/setup_spec.rb

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1344,5 +1344,11 @@ def lock_with(ruby_version = nil)
13441344
expect(last_command.stdboth).not_to include "FAIL"
13451345
expect(err).to include "private method `require'"
13461346
end
1347+
1348+
it "takes care of requiring rubygems" do
1349+
sys_exec("#{Gem.ruby} -I#{lib_dir} -e \"puts require('bundler/setup')\"", "RUBYOPT" => "--disable=gems")
1350+
1351+
expect(last_command.stdboth).to eq("true")
1352+
end
13471353
end
13481354
end

task/release.rake

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# frozen_string_literal: true
22

3-
require "bundler/gem_tasks"
3+
require_relative "../lib/bundler/gem_tasks"
44
task :build => ["build_metadata"] do
55
Rake::Task["build_metadata:clean"].tap(&:reenable).real_invoke
66
end

0 commit comments

Comments
 (0)