Merge pull request #6671 from hexdevs/sb-fix-shoulda-matchers-warn-6670

Ensure CustomOrgLink#active tests inclusion in [true, false]

Author: compwron

spec/models/custom_org_link_spec.rb

@@ -5,7 +5,6 @@
   it { is_expected.to validate_presence_of :text }
   it { is_expected.to validate_presence_of :url }
   it { is_expected.to validate_length_of(:text).is_at_most described_class::TEXT_MAX_LENGTH }
-  it { is_expected.to validate_inclusion_of(:active).in_array [true, false] }
 
   describe "#trim_name" do
     let(:casa_org) { create(:casa_org) }
@@ -27,4 +26,14 @@
     it { is_expected.not_to allow_value("example.com").for(:url) }
     it { is_expected.not_to allow_value("some arbitrary string").for(:url) }
   end
+
+  describe "#active" do
+    it "only allows true or false" do
+      casa_org = build(:casa_org)
+
+      expect(build(:custom_org_link, casa_org: casa_org, active: false)).to be_valid
+      expect(build(:custom_org_link, casa_org: casa_org, active: true)).to be_valid
+      expect(build(:custom_org_link, casa_org: casa_org, active: nil)).to be_invalid
+    end
+  end
 end