Refactor codebase to use 'cpp11'#438
Open
pachadotdev wants to merge 17 commits into
Open
Conversation
Author
|
@estebanlp here's the other, same ABI thing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dear 'httpuv' maintainers:
I hope you are doing well.
I took all the feedback from the previous thread, and decided to try with cpp11.
I registed functions of the form
my_fun_()on C++ side and roxygenised wrappers of the formmy_fun()on R side, the changes go smoothly.Similar to 'later' (PR 269), but without a side 'httpuvtest' package as there is no API here, I looped multiple
devtools::check()calls for different pairs such as "Clang + CXX17/20/23" and "GCC + CXX17/20/23". In addition, same for 'later', I use https://github.com/wch/r-source to runmake build-r-devel && make check-develto build R-devel in a sub-directory and there install devtools and all the dependencies to run an extradevtools::check().I know this testing may read a circular but Clang usually shows things that GCC accepts silently.
Please let me know about this PR. I tried to edit as little as possible.
Be safe and well,
MVS