Merge pull request #67 from KevinBusch/issue-66

Removed e.preventDefault() from window object touchEnd event.  Added …

Author: wintondeshong

src/atoms/forms/canvas-sketch/tools/line-canvas-draw-tool.ts

@@ -269,9 +269,6 @@ class LineCanvasDrawTool extends BaseCanvasDrawTool implements CanvasDrawTool {
 
     private _onTouchEndWindow(e: TouchEvent): void {
         this._finishStroke();
-
-        // Don't allow touch events to be called
-        e.preventDefault();
     }
 
     private _onTouchMoveCanvas(e: TouchEvent): void {
@@ -283,7 +280,7 @@ class LineCanvasDrawTool extends BaseCanvasDrawTool implements CanvasDrawTool {
             this._move(touchPosition);
         }
 
-        // Don't allow touch events to be called
+        // prevents scrolling screen (if inside scrollable content)
         e.preventDefault();
     }
 
@@ -296,7 +293,8 @@ class LineCanvasDrawTool extends BaseCanvasDrawTool implements CanvasDrawTool {
             this._startStroke(touchPosition);
         }
 
-        // Don't allow touch events to be called
+        // prevents click event from firing when not moving / gesturing with touch
+        // effectively duplicating drawing stroke
         e.preventDefault();
     }
 

src/atoms/forms/canvas-sketch/tools/pan-canvas-tool.ts

@@ -178,9 +178,6 @@ class PanCanvasTool {
 
     private _onTouchEndWindow(e: TouchEvent): void {
         this._finishPan();
-
-        // Don't allow touch events to be called
-        e.preventDefault();
     }
 
     private _onTouchMoveCanvas(e: TouchEvent): void {
@@ -192,7 +189,7 @@ class PanCanvasTool {
             this._pan(touchPosition);
         }
 
-        // Don't allow touch events to be called
+        // prevents scrolling screen (if inside scrollable content)
         e.preventDefault();
     }
 
@@ -205,7 +202,7 @@ class PanCanvasTool {
             this._startPan(touchPosition);
         }
 
-        // Don't allow touch events to be called
+        // prevents click event from firing when not moving / gesturing with touch
         e.preventDefault();
     }
 

src/atoms/forms/canvas-sketch/tools/pencil-canvas-draw-tool.ts

@@ -344,9 +344,6 @@ class PencilCanvasDrawTool extends BaseCanvasDrawTool
 
     private _onTouchEndWindow(e: TouchEvent): void {
         this._finishStroke();
-
-        // Don't allow touch events to be called
-        e.preventDefault();
     }
 
     private _onTouchMoveCanvas(e: TouchEvent): void {
@@ -358,7 +355,7 @@ class PencilCanvasDrawTool extends BaseCanvasDrawTool
             this._move(touchPosition);
         }
 
-        // Don't allow touch events to be called
+        // prevents scrolling screen (if inside scrollable content)
         e.preventDefault();
     }
 
@@ -371,7 +368,8 @@ class PencilCanvasDrawTool extends BaseCanvasDrawTool
             this._startStroke(touchPosition);
         }
 
-        // Don't allow touch events to be called
+        // prevents click event from firing when not moving / gesturing with touch
+        // effectively duplicating drawing stroke
         e.preventDefault();
     }