Skip to content

Commit 434e6f5

Browse files
committed
Add missing returns (osrf#23)
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
1 parent b8ef52f commit 434e6f5

5 files changed

+5
-0
lines changed

rcljava/src/main/cpp/org_ros2_rcljava_detail_QosIncompatibleStatus.cpp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -51,6 +51,7 @@ Java_org_ros2_rcljava_detail_QosIncompatibleStatus_nativeFromRCLEvent(
5151
if (!p) {
5252
rcljava_throw_exception(
5353
env, "java/lang/IllegalArgumentException", "passed rmw object handle is NULL");
54+
return;
5455
}
5556
// TODO(ivanpauno): class and field lookup could be done at startup time
5657
jclass clazz = env->GetObjectClass(self);

rcljava/src/main/cpp/org_ros2_rcljava_publisher_statuses_LivelinessLost.cpp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,7 @@ Java_org_ros2_rcljava_publisher_statuses_LivelinessLost_nativeFromRCLEvent(
5050
if (!p) {
5151
rcljava_throw_exception(
5252
env, "java/lang/IllegalArgumentException", "passed rmw object handle is NULL");
53+
return;
5354
}
5455
// TODO(ivanpauno): class and field lookup could be done at startup time
5556
jclass clazz = env->GetObjectClass(self);

rcljava/src/main/cpp/org_ros2_rcljava_publisher_statuses_OfferedDeadlineMissed.cpp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,7 @@ Java_org_ros2_rcljava_publisher_statuses_OfferedDeadlineMissed_nativeFromRCLEven
5050
if (!p) {
5151
rcljava_throw_exception(
5252
env, "java/lang/IllegalArgumentException", "passed rmw object handle is NULL");
53+
return;
5354
}
5455
// TODO(ivanpauno): class and field lookup could be done at startup time
5556
jclass clazz = env->GetObjectClass(self);

rcljava/src/main/cpp/org_ros2_rcljava_subscription_statuses_LivelinessChanged.cpp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,7 @@ Java_org_ros2_rcljava_subscription_statuses_LivelinessChanged_nativeFromRCLEvent
5050
if (!p) {
5151
rcljava_throw_exception(
5252
env, "java/lang/IllegalArgumentException", "passed rmw object handle is NULL");
53+
return;
5354
}
5455
// TODO(ivanpauno): class and field lookup could be done at startup time
5556
jclass clazz = env->GetObjectClass(self);

rcljava/src/main/cpp/org_ros2_rcljava_subscription_statuses_RequestedDeadlineMissed.cpp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,7 @@ Java_org_ros2_rcljava_subscription_statuses_RequestedDeadlineMissed_nativeFromRC
5050
if (!p) {
5151
rcljava_throw_exception(
5252
env, "java/lang/IllegalArgumentException", "passed rmw object handle is NULL");
53+
return;
5354
}
5455
// TODO(ivanpauno): class and field lookup could be done at startup time
5556
jclass clazz = env->GetObjectClass(self);

0 commit comments

Comments
 (0)