-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Open
Description
Explain what you would like to see improved and how.
In line 343 of interpreter/CMakeLists.txt, you defined ROOT_LLVM_MAIN_SRC_DIR with trailing slash.
set(ROOT_LLVM_MAIN_SRC_DIR "${CMAKE_CURRENT_SOURCE_DIR}/llvm-project/llvm/")
In the following codes, this path is used to construct new paths with other paths with leading slashes, which leads to malformed paths with double slash:
if(EXISTS ${ROOT_LLVM_MAIN_SRC_DIR}/utils/lit/lit.py)
set(LLVM_LIT ${ROOT_LLVM_MAIN_SRC_DIR}/utils/lit/lit.py CACHE PATH "The location of the lit test runner.")
add_subdirectory(${ROOT_LLVM_MAIN_SRC_DIR}/utils/FileCheck utils/FileCheck)
add_subdirectory(${ROOT_LLVM_MAIN_SRC_DIR}/utils/count utils/count)
add_subdirectory(${ROOT_LLVM_MAIN_SRC_DIR}/utils/not utils/not)
...
I think it's better to remove the trailing slash at the time of definition:
set(ROOT_LLVM_MAIN_SRC_DIR "${CMAKE_CURRENT_SOURCE_DIR}/llvm-project/llvm")
ROOT version
N/A
Installation method
N/A
Operating system
N/A
Additional context
No response
Reactions are currently unavailable
Metadata
Metadata
Assignees
Type
Projects
Status
No status