Skip to content

Shouldn't rock-bundle-find omit the full path if possible, even if it is not passed as relative path? #39

@moooeeeep

Description

@moooeeeep

I just noticed that rock-bundle-sel gives different output when given a relative path to the bundle vs when given just the name:

devel@rock-docker:/opt/workspace$ echo $ROCK_BUNDLE_PATH
/opt/workspace/bundles
devel@rock-docker:/opt/workspace$ rock-bundle-find bundle_name
[DEPRECATED] utilrb/hash/slice is deprecated, [...]
/opt/workspace/bundles/bundle_name
devel@rock-docker:/opt/workspace$ rock-bundle-find bundles/bundle_name
[DEPRECATED] utilrb/hash/slice is deprecated, [...]
bundle_name

This seems strange to me. IMO If it can find the bundle via the name, and it is located at the ROCK_BUNDLE_PATH, it should also return just the name and not the path.

I think the script should check if the bundle is registered here too and adjust the output accordingly. Or can we ditch the registered-check there altogether because only registered bundles are iterated in the first place? Quiet output doesn't seem to make sense there, does it?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions