Skip to content

Commit 002ddd9

Browse files
authored
Merge branch 'AliceO2Group:master' into TPC---Add-moving-window-for-async-qc---DCAr-versus-Eta
2 parents 0390045 + 3be71b2 commit 002ddd9

769 files changed

Lines changed: 38646 additions & 3034 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

CODEOWNERS

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,9 +17,10 @@
1717
/DATA/testing/detectors/TRD
1818
/DATA/testing/detectors/ZDC
1919

20-
/MC @sawenzel @chiarazampolli @jackal1-66
20+
/MC @sawenzel @jackal1-66
2121

2222
# PWG experts
23+
/MC/*/ALICE3 @njacazio
2324
/MC/*/PWGHF @AliceO2Group/reviewers-pwg-hf
2425
/MC/*/PWGLF @AliceO2Group/reviewers-pwg-lf
2526
/MC/*/PWGEM @AliceO2Group/reviewers-pwg-em

DATA/README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -227,7 +227,7 @@ export WORKFLOW_PARAMETERS= # Additiona
227227
export RECO_NUM_NODES_OVERRIDE=0 # Override the number of EPN compute nodes to use (default is specified in description library file)
228228
export NHBPERTF=256 # Number of HBF per TF
229229
230-
/opt/alisw/el8/GenTopo/bin/gen_topo.sh > $HOME/gen_topo_output.xml
230+
/opt/alisw/el9/GenTopo/bin/gen_topo.sh > $HOME/gen_topo_output.xml
231231
[drohr@epn245 test]$ ./run.sh
232232
Loading ODC/0.36-1
233233
Loading requirement: BASE/1.0 GCC-Toolchain/v10.2.0-alice2-3 fmt/7.1.0-10 FairLogger/v1.9.1-7 zlib/v1.2.8-8 OpenSSL/v1.0.2o-9 libpng/v1.6.34-9 sqlite/v3.15.0-2 libffi/v3.2.1-2 FreeType/v2.10.1-8 Python/v3.6.10-12 Python-modules/1.0-16 boost/v1.75.0-13 ZeroMQ/v4.3.3-6 ofi/v1.7.1-8 asio/v1.19.1-2 asiofi/v0.5.1-2 DDS/3.5.16-5 FairMQ/v1.4.40-4
@@ -277,7 +277,7 @@ export WORKFLOW_PARAMETERS=EVENT_DISPLAY,CTF,GPU # Additiona
277277
export RECO_NUM_NODES_OVERRIDE=0 # Override the number of EPN compute nodes to use (default is specified in description library file)
278278
export NHBPERTF=256 # Number of HBF per TF
279279
280-
/opt/alisw/el8/GenTopo/bin/gen_topo.sh > $HOME/gen_topo_output.xml
280+
/opt/alisw/el9/GenTopo/bin/gen_topo.sh > $HOME/gen_topo_output.xml
281281
[drohr@epn245 test]$ ./run.sh
282282
Loading ODC/0.36-1
283283
Loading requirement: BASE/1.0 GCC-Toolchain/v10.2.0-alice2-3 fmt/7.1.0-10 FairLogger/v1.9.1-7 zlib/v1.2.8-8 OpenSSL/v1.0.2o-9 libpng/v1.6.34-9 sqlite/v3.15.0-2 libffi/v3.2.1-2 FreeType/v2.10.1-8 Python/v3.6.10-12 Python-modules/1.0-16 boost/v1.75.0-13 ZeroMQ/v4.3.3-6 ofi/v1.7.1-8 asio/v1.19.1-2 asiofi/v0.5.1-2 DDS/3.5.16-5 FairMQ/v1.4.40-4

DATA/common/README.md

Lines changed: 1 addition & 51 deletions
Original file line numberDiff line numberDiff line change
@@ -1,51 +1 @@
1-
The `setenv-sh` script sets the following environment options
2-
* `NTIMEFRAMES`: Number of time frames to process.
3-
* `TFDELAY`: Delay in seconds between publishing time frames (1 / rate).
4-
* `NGPUS`: Number of GPUs to use, data distributed round-robin.
5-
* `GPUTYPE`: GPU Tracking backend to use, can be CPU / CUDA / HIP / OCL / OCL2.
6-
* `SHMSIZE`: Size of the global shared memory segment.
7-
* `DDSHMSIZE`: Size of shared memory unmanaged region for DataDistribution Input.
8-
* `GPUMEMSIZE`: Size of allocated GPU memory (if GPUTYPE != CPU)
9-
* `HOSTMEMSIZE`: Size of allocated host memory for GPU reconstruction (0 = default).
10-
* For `GPUTYPE = CPU`: TPC Tracking scratch memory size. (Default 0 -> dynamic allocation.)
11-
* Otherwise : Size of page-locked host memory for GPU processing. (Defauls 0 -> 1 GB.)
12-
* `CREATECTFDICT`: Create CTF dictionary.
13-
* `SAVECTF`: Save the CTF to a root file.
14-
* 0: Read `ctf_dictionary.root` as input.
15-
* 1: Create `ctf_dictionary.root`. Note that this was already done automatically if the raw data was simulated with `full_system_test.sh`.
16-
* `SYNCMODE`: Run only reconstruction steps of the synchronous reconstruction.
17-
* Note that there is no `ASYNCMODE` but instead the `CTFINPUT` option already enforces asynchronous processing.
18-
* `NUMAGPUIDS`: NUMAID-aware GPU id selection. Needed for the full EPN configuration with 8 GPUs, 2 NUMA domains, 4 GPUs per domain.
19-
In this configuration, 2 instances of `dpl-workflow.sh` must run in parallel.
20-
To be used in combination with `NUMAID` to select the id per workflow.
21-
`start_tmux.sh` will set up these variables automatically.
22-
* `NUMAID`: SHM segment id to use for shipping data as well as set of GPUs to use (use `0` / `1` for 2 NUMA domains, 0 = GPUS `0` to `NGPUS - 1`, 1 = GPUS `NGPUS` to `2 * NGPUS - 1`)
23-
* 0: Runs all reconstruction steps, of sync and of async reconstruction, using raw data input.
24-
* 1: Runs only the steps of synchronous reconstruction, using raw data input.
25-
* `EXTINPUT`: Receive input from raw FMQ channel instead of running o2-raw-file-reader.
26-
* 0: `dpl-workflow.sh` can run as standalone benchmark, and will read the input itself.
27-
* 1: To be used in combination with either `datadistribution.sh` or `raw-reader.sh` or with another DataDistribution instance.
28-
* `CTFINPUT`: Read input from CTF ROOT file. This option is incompatible to EXTINPUT=1. The CTF ROOT file can be stored via SAVECTF=1.
29-
* `NHBPERTF`: Time frame length (in HBF)
30-
* `GLOBALDPLOPT`: Global DPL workflow options appended to o2-dpl-run.
31-
* `EPNPIPELINES`: Set default EPN pipeline multiplicities.
32-
Normally the workflow will start 1 dpl device per processor.
33-
For some of the CPU parts, this is insufficient to keep step with the GPU processing rate, e.g. one ITS-TPC matcher on the CPU is slower than the TPC tracking on multiple GPUs.
34-
This option adds some multiplicies for CPU processes using DPL's pipeline feature.
35-
The settings were tuned for EPN processing with 4 GPUs (i.e. the default multiplicities are per NUMA domain).
36-
The multiplicities are scaled with the `NGPUS` setting, i.e. with 1 GPU only 1/4th are applied.
37-
You can pass an option different to 1, and than it will be applied as factor on top of the multiplicities.
38-
It is auto-selected by `start-tmux.sh`.
39-
* `SEVERITY`: Log verbosity (e.g. info or error, default: info)
40-
* `INFOLOGGER_SEVERITY`: Min severity for messages sent to Infologger. (default: `$SEVERITY`)
41-
* `SHMTHROW`: Throw exception when running out of SHM memory.
42-
It is suggested to leave this enabled (default) on tests on the laptop to get an actual error when it runs out of memory.
43-
This is disabled in `start_tmux.sh`, to avoid breaking the processing while there is a chance that another process might free memory and we can continue.
44-
* `NORATELOG`: Disable FairMQ Rate Logging.
45-
* `INRAWCHANNAME`: FairMQ channel name used by the raw proxy, must match the name used by DataDistribution.
46-
* `WORKFLOWMODE`: run (run the workflow (default)), print (print the command to stdout), dds (create partial DDS topology)
47-
* `FILEWORKDIR`: directory for all input / output files. E.g. grp / geometry / dictionaries etc. are read from here, and dictionaries / ctf / etc. are written to there.
48-
Some files have more fine grained control via other environment variables (e.g. to store the CTF to somewhere else). Such variables are initialized to `$FILEWORKDIR` by default but can be overridden.
49-
* `EPNSYNCMODE`: Specify that this is a workflow running on the EPN for synchronous processing, e.g. logging goes to InfoLogger, DPL metrics to to the AliECS monitoring, etc.
50-
* `BEAMTYPE`: Beam type, must be PbPb, pp, pPb, cosmic, technical.
51-
* `IS_SIMULATED_DATA` : 1 for MC data, 0 for RAW data.
1+
For a reference to available env-variables, please check https://github.com/AliceO2Group/AliceO2/blob/dev/prodtests/full-system-test/documentation/env-variables.md

DATA/common/gen_topo_helper_functions.sh

Lines changed: 31 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -49,11 +49,21 @@ has_detector_matching()
4949
[[ $WORKFLOW_DETECTORS_MATCHING =~ (^|,)"ALL"(,|$) ]] || [[ $WORKFLOW_DETECTORS_MATCHING =~ (^|,)"$1"(,|$) ]]
5050
}
5151

52+
has_detector_gpu()
53+
{
54+
has_detector $1 && [[ $WORKFLOW_DETECTORS_GPU =~ (^|,)"$1"(,|$) ]]
55+
}
56+
5257
has_secvtx_source()
5358
{
5459
[[ $SVERTEXING_SOURCES =~ (^|,)"ALL"(,|$) ]] || [[ $SVERTEXING_SOURCES =~ (^|,)"$1"(,|$) ]]
5560
}
5661

62+
has_detector_in_secvtx_sources()
63+
{
64+
[[ $SVERTEXING_SOURCES =~ (^|,)"ALL"(,|$) ]] || [[ $SVERTEXING_SOURCES =~ (^|,|-)"$1"(-|,|$) ]]
65+
}
66+
5767
has_detector_qc()
5868
{
5969
has_detector $1 && [[ $WORKFLOW_DETECTORS_QC =~ (^|,)"$1"(,|$) ]]
@@ -137,6 +147,11 @@ has_detectors_flp_processing()
137147
_check_multiple has_detector_flp_processing "$@"
138148
}
139149

150+
has_detectors_gpu()
151+
{
152+
_check_multiple has_detector_gpu "$@"
153+
}
154+
140155
workflow_has_parameters()
141156
{
142157
_check_multiple workflow_has_parameter "$@"
@@ -252,19 +267,22 @@ add_W() # Add binarry to workflow command USAGE: add_W [BINARY] [COMMAND_LINE_OP
252267
WORKFLOW+=$WFADD
253268
}
254269

255-
if [[ "${GEN_TOPO_DEPLOYMENT_TYPE:-}" == "ALICE_STAGING" ]]; then
256-
GEN_TOPO_QC_CONSUL_SERVER=ali-staging.cern.ch
257-
else
258-
GEN_TOPO_QC_CONSUL_SERVER=alio2-cr1-hv-con01.cern.ch
270+
if [[ ${EPNSYNCMODE:-0} == 1 ]]; then
271+
if [[ "${GEN_TOPO_DEPLOYMENT_TYPE:-}" == "ALICE_STAGING" ]]; then
272+
GEN_TOPO_QC_CONSUL_SERVER=ali-staging.cern.ch
273+
else
274+
GEN_TOPO_QC_CONSUL_SERVER=alio2-cr1-hv-con01.cern.ch
275+
fi
276+
GEN_TOPO_QC_APRICOT_SERVER=`curl -s "http://${GEN_TOPO_QC_CONSUL_SERVER}:8500/v1/kv/o2/runtime/aliecs/vars/apricot_endpoint?raw"`
259277
fi
260-
GEN_TOPO_QC_APRICOT_SERVER=`curl -s "http://${GEN_TOPO_QC_CONSUL_SERVER}:8500/v1/kv/o2/runtime/aliecs/vars/apricot_endpoint?raw"`
261278

262279
add_QC_from_consul()
263280
{
281+
[[ ${EPNSYNCMODE:-0} == 1 ]] || { echo "Error fetching QC JSON $1: consul server only set for EPNSYNCMODE == 1 " 1>&2 && exit 1; }
264282
if [[ ! -z ${GEN_TOPO_QC_JSON_FILE:-} ]]; then
265283
curl -s -o $GEN_TOPO_QC_JSON_FILE "http://${GEN_TOPO_QC_CONSUL_SERVER}:8500/v1/kv${1}?raw"
266284
if [[ $? != 0 ]]; then
267-
echo "Error fetching QC JSON $1"
285+
echo "Error fetching QC JSON $1 (1)" 1>&2
268286
exit 1
269287
fi
270288
QC_CONFIG_ARG="json://${GEN_TOPO_QC_JSON_FILE}"
@@ -276,14 +294,15 @@ add_QC_from_consul()
276294

277295
add_QC_from_apricot()
278296
{
297+
[[ ${EPNSYNCMODE:-0} == 1 ]] || { echo "Error fetching QC JSON $1: apricot server only set for EPNSYNCMODE == 1 " 1>&2 && exit 1; }
279298
if [[ ! -z ${GEN_TOPO_QC_JSON_FILE:-} ]]; then
280-
if [[ ${1} =~ "?" ]]; then
281-
curl -s -o $GEN_TOPO_QC_JSON_FILE "${GEN_TOPO_QC_APRICOT_SERVER}/${1}\&process=true"
282-
else
283-
curl -s -o $GEN_TOPO_QC_JSON_FILE "${GEN_TOPO_QC_APRICOT_SERVER}/${1}?process=true"
284-
fi
299+
if [[ ${1} =~ "?" ]]; then
300+
curl -s -o $GEN_TOPO_QC_JSON_FILE "${GEN_TOPO_QC_APRICOT_SERVER}/${1}\&process=true"
301+
else
302+
curl -s -o $GEN_TOPO_QC_JSON_FILE "${GEN_TOPO_QC_APRICOT_SERVER}/${1}?process=true"
303+
fi
285304
if [[ $? != 0 ]]; then
286-
echo "Error fetching QC JSON $1"
305+
echo "Error fetching QC JSON $1 (2)" 1>&2
287306
exit 1
288307
fi
289308
QC_CONFIG_ARG="json://${GEN_TOPO_QC_JSON_FILE}"

DATA/common/setenv.sh

Lines changed: 14 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,7 @@ if [[ ! -z ${WORKFLOW_DETECTORS_EXCLUDE:-} ]]; then
4343
done
4444
fi
4545

46+
if [[ -z "${WORKFLOW_DETECTORS_GPU+x}" ]]; then export WORKFLOW_DETECTORS_GPU="TPC"; fi
4647
if [[ -z "${WORKFLOW_DETECTORS_QC+x}" ]] || [[ "0$WORKFLOW_DETECTORS_QC" == "0ALL" ]]; then export WORKFLOW_DETECTORS_QC="$WORKFLOW_DETECTORS,$LIST_OF_GLORECO,TOF_MATCH"; fi
4748
if [[ -z "${WORKFLOW_DETECTORS_CALIB+x}" ]] || [[ "0$WORKFLOW_DETECTORS_CALIB" == "0ALL" ]]; then export WORKFLOW_DETECTORS_CALIB=$WORKFLOW_DETECTORS; fi
4849
if [[ -z "${WORKFLOW_DETECTORS_RECO+x}" ]] || [[ "0$WORKFLOW_DETECTORS_RECO" == "0ALL" ]]; then export WORKFLOW_DETECTORS_RECO=$WORKFLOW_DETECTORS; fi
@@ -90,7 +91,7 @@ if [[ -z "${FILEWORKDIR:-}" ]]; then export FILEWORKDIR=`pwd`; fi #
9091
if [[ -z "${FILEWORKDIRRUN:-}" ]]; then export FILEWORKDIRRUN=$FILEWORKDIR; fi # directory where to find the run-related files (grp, collision context)
9192
if [[ -z "${RAWINPUTDIR:-}" ]]; then export RAWINPUTDIR=$FILEWORKDIR; fi # Directory where to find input files (raw files / raw tf files / ctf files)
9293
if [[ -z "${EPNSYNCMODE:-}" ]]; then export EPNSYNCMODE=0; fi # Is this workflow supposed to run on EPN for sync processing? Will enable InfoLogger / metrics / fetching QC JSONs from consul...
93-
if [[ -z "${BEAMTYPE:-}" ]]; then export BEAMTYPE=PbPb; fi # Beam type, must be PbPb, pp, pPb, cosmic, technical
94+
if [[ -z "${BEAMTYPE:-}" ]]; then export BEAMTYPE=PbPb; fi # Beam type, must be PbPb, pp, pPb, pO, Op, OO, NeNe cosmic, technical
9495
if [[ -z "${RUNTYPE:-}" ]]; then export RUNTYPE=Standalone; fi # Run Type, standalone for local tests, otherwise PHYSICS, COSMICS, TECHNICAL, SYNTHETIC
9596
if [[ -z "${IS_SIMULATED_DATA:-}" && $RUNTYPE == "SYNTHETIC" ]]; then export IS_SIMULATED_DATA=1; fi # For SYNTHETIC runs we always process simulated data
9697
if [[ -z "${IS_SIMULATED_DATA:-}" && ( $RUNTYPE == "PHYSICS" || $RUNTYPE == "COSMICS" ) ]]; then export IS_SIMULATED_DATA=0; fi # For PHYSICS runs we always process simulated data
@@ -102,6 +103,12 @@ if [[ -z "${EPN2EOS_METAFILES_DIR:-}" ]]; then EPN2EOS_METAFILES_DIR="/dev/null"
102103
if [[ -z "${DCSCCDBSERVER:-}" ]]; then export DCSCCDBSERVER="http://alio2-cr1-flp199-ib:8083"; fi # server for transvering calibration data to DCS
103104
if [[ -z "${DCSCCDBSERVER_PERS:-}" ]]; then export DCSCCDBSERVER_PERS="http://alio2-cr1-flp199-ib:8084"; fi # persistent server for transvering calibration data to DCS
104105

106+
if [[ $BEAMTYPE == "pO" ]] || [[ $BEAMTYPE == "Op" ]] || [[ $BEAMTYPE == "Op" ]] || [[ $BEAMTYPE == "OO" ]] || [[ $BEAMTYPE == "NeNe" ]] ; then
107+
export LIGHTNUCLEI=1
108+
else
109+
export LIGHTNUCLEI=0
110+
fi
111+
105112
if [[ $EPNSYNCMODE == 0 ]]; then
106113
if [[ -z "${SHMSIZE:-}" ]]; then export SHMSIZE=$(( 8 << 30 )); fi # Size of shared memory for messages
107114
if [[ -z "${NGPUS:-}" ]]; then export NGPUS=1; fi # Number of GPUs to use, data distributed round-robin
@@ -143,7 +150,7 @@ if [[ `uname` == Darwin ]]; then export UDS_PREFIX=; else export UDS_PREFIX="@";
143150

144151
# Env variables required for workflow setup
145152
if [[ $SYNCMODE == 1 ]]; then
146-
if [[ -z "${WORKFLOW_DETECTORS_MATCHING+x}" ]]; then export WORKFLOW_DETECTORS_MATCHING="ITSTPC,ITSTPCTRD,ITSTPCTOF,ITSTPCTRDTOF,PRIMVTX"; fi # Select matchings that are enabled in sync mode
153+
if [[ -z "${WORKFLOW_DETECTORS_MATCHING+x}" ]]; then export WORKFLOW_DETECTORS_MATCHING="ITSTPC,ITSTPCTRD,ITSTPCTOF,ITSTPCTRDTOF,PRIMVTX,SECVTX"; fi # Select matchings that are enabled in sync mode
147154
else
148155
if [[ -z "${WORKFLOW_DETECTORS_MATCHING+x}" ]]; then export WORKFLOW_DETECTORS_MATCHING="ALL"; fi # All matching / vertexing enabled in async mode
149156
fi
@@ -157,8 +164,8 @@ DISABLE_ROOT_INPUT="--disable-root-input"
157164
# Special detector related settings
158165
if [[ -z "${TPC_CORR_SCALING:-}" ]]; then # TPC corr.map lumi scaling options, any combination of --lumi-type <0,1,2> --corrmap-lumi-mode <0,1> and TPCCorrMap... configurable param
159166
TPC_CORR_SCALING=
160-
if [[ $BEAMTYPE == "pp" ]] && has_detector CTP; then TPC_CORR_SCALING+="--lumi-type 1"; fi
161-
if [[ $BEAMTYPE == "PbPb" ]] && has_detector CTP; then TPC_CORR_SCALING+="--lumi-type 1 TPCCorrMap.lumiInstFactor=2.414"; fi
167+
if [[ $BEAMTYPE == "pp" || $LIGHTNUCLEI == "1" ]] && has_detector CTP; then TPC_CORR_SCALING+="--lumi-type 1 --corrmap-lumi-mode 1"; fi
168+
if [[ $BEAMTYPE == "PbPb" ]] && has_detector CTP; then TPC_CORR_SCALING+="--lumi-type 1 --corrmap-lumi-mode 1 TPCCorrMap.lumiInstFactor=2.414"; fi
162169
if [[ $BEAMTYPE == "cosmic" ]]; then TPC_CORR_SCALING=" TPCCorrMap.lumiMean=-1;"; fi # for COSMICS we disable all corrections
163170
export TPC_CORR_SCALING=$TPC_CORR_SCALING
164171
fi
@@ -169,9 +176,6 @@ ITSMFT_STROBES=""
169176
[[ ! -z ${ITS_STROBE:-} ]] && ITSMFT_STROBES+="ITSAlpideParam.roFrameLengthInBC=$ITS_STROBE;"
170177
[[ ! -z ${MFT_STROBE:-} ]] && ITSMFT_STROBES+="MFTAlpideParam.roFrameLengthInBC=$MFT_STROBE;"
171178

172-
MFTMCH_NCANDIDATES_OPT=
173-
[[ ! -z ${MUON_MATCHING_NCANDIDATES:-} ]] && MFTMCH_NCANDIDATES_OPT+="FwdMatching.saveMode=3;FwdMatching.nCandidates=${MUON_MATCHING_NCANDIDATES};"
174-
175179

176180
# Set active reconstruction steps (defaults added according to SYNCMODE)
177181
for i in `echo $LIST_OF_GLORECO | sed "s/,/ /g"`; do
@@ -191,6 +195,7 @@ TRD_SOURCES=
191195
TOF_SOURCES=
192196
HMP_SOURCES=
193197
TRACK_SOURCES=
198+
: ${TRACK_SOURCES_GLO:=}
194199
has_detectors_reco ITS TPC && has_detector_matching ITSTPC && add_comma_separated TRACK_SOURCES "ITS-TPC"
195200
has_detectors_reco TPC TRD && has_detector_matching TPCTRD && { add_comma_separated TRD_SOURCES TPC; add_comma_separated TRACK_SOURCES "TPC-TRD"; }
196201
has_detectors_reco ITS TPC TRD && has_detector_matching ITSTPC && has_detector_matching ITSTPCTRD && { add_comma_separated TRD_SOURCES ITS-TPC; add_comma_separated TRACK_SOURCES "ITS-TPC-TRD"; }
@@ -207,6 +212,8 @@ has_detectors_reco HMP TPC TOF && has_detector_matching TPCTOF && add_comma_sepa
207212
has_detectors_reco HMP TPC TRD TOF && has_detector_matching TPCTRD && has_detector_matching TPCTRDTOF && add_comma_separated HMP_SOURCES "TPC-TRD-TOF"
208213
has_detectors_reco MFT MCH && has_detector_matching MFTMCH && add_comma_separated TRACK_SOURCES "MFT-MCH"
209214
has_detectors_reco MCH MID && has_detector_matching MCHMID && add_comma_separated TRACK_SOURCES "MCH-MID"
215+
[[ "0$TRACK_SOURCES_GLO" == "0" ]] && TRACK_SOURCES_GLO=$TRACK_SOURCES
216+
210217
for det in `echo $LIST_OF_DETECTORS | sed "s/,/ /g"`; do
211218
if [[ $LIST_OF_ASYNC_RECO_STEPS =~ (^| )${det}( |$) ]]; then
212219
has_detector ${det} && has_processing_step ${det}_RECO && add_comma_separated TRACK_SOURCES "$det"
@@ -237,12 +244,6 @@ fi
237244
[[ ! -z $VERTEXING_SOURCES ]] && PVERTEX_CONFIG+=" --vertexing-sources $VERTEXING_SOURCES"
238245
[[ ! -z $VERTEX_TRACK_MATCHING_SOURCES ]] && PVERTEX_CONFIG+=" --vertex-track-matching-sources $VERTEX_TRACK_MATCHING_SOURCES"
239246

240-
if [[ -z ${SVERTEXING_SOURCES:-} ]]; then
241-
SVERTEXING_SOURCES="$VERTEXING_SOURCES"
242-
elif [[ "${SVERTEXING_SOURCES^^}" == "NONE" ]]; then
243-
SVERTEXING_SOURCES=
244-
fi
245-
246247
# this option requires well calibrated timing beween different detectors, at the moment suppress it
247248
#has_detector_reco FT0 && PVERTEX_CONFIG+=" --validate-with-ft0"
248249

0 commit comments

Comments
 (0)