Improve pinhole lookup error message #12119
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alsom remove some setrange redundant lookup that slipped in.
Wumpf
added
the
exclude from changelog
|
Web viewer built successfully.
View image diff on kitdiff. Note: This comment is updated whenever you push a commit. |
IsseW
reviewed
Dec 5, 2025
| ); | ||
| // This can happen with various frame id mismatches. | ||
| return Err(format!( | ||
| "Expected well-defined pinhole transforming into the transform frame {:?}, but look-up in active transform tree failed.", |
Member
There was a problem hiding this comment.
This error still feels pretty unspecific, but maybe we don't have more context to give here?
Member
Author
There was a problem hiding this comment.
hmmmmmm agreed. Having a hard time to make it better tbh.
One case I encountered that triggers this is some kinds malformed pinholes... lemme dig a bit more first, I'll come back with a new suggestion afterwards.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related
What
also remove some strange redundant lookup that slipped in.