`isDashboard` doesn't handle current feed URL, maybe needs cleanup

[SunsetTechuila]

Current feed URL: https://github.com/feed

https://github.com/dashboard-feed still works, but it's clearly a leftover.

What are these URLs?

github-url-detection/index.ts

Lines 78 to 83 in 6f5d835

	'https://github.com/?tab=repositories', // Gotcha for `isUserProfileRepoTab`
	'https://github.com/?tab=stars', // Gotcha for `isUserProfileStarsTab`
	'https://github.com/?tab=followers', // Gotcha for `isUserProfileFollowersTab`
	'https://github.com/?tab=following', // Gotcha for `isUserProfileFollowingTab`
	'https://github.com/?tab=overview', // Gotcha for `isUserProfileMainTab`
	'https://github.com?search=1', // Gotcha for `isRepoTree`

#4 and #34 don't explain anything. Were they added just because you can add any query params to github.com and they will be ignored? Or did those params used to work?

[fregante]

By "gotcha" we meant URLs that look like other pages but aren't.

For example /fregante/settings might look like a settings page but it's just a repo, so they appear as isRepo. The examples only exist to ensure that we don't misidentify pages.

/?tab=repositories is indeed a dashboard URL but only because the query parameter is ignored by GitHub.

[fregante]

To resolve this issue:

• introduce isFeed()
• move feed URLs to this new check
• rename isDashboard to isRoot for clarity
• still export a deprecated isDashboard so we don't have to release a new major version

[SunsetTechuila]

I don't think isRoot is a good name for a helper that checks whether you are on the page that says "Dashboard" at the top and is accessible via the URL containing the word "dashboard": https://github.com/dashboard

[SunsetTechuila]

What https://github.com/orgs/refined-github/dashboard is?

If it is a dashboard:

• how is its content different from https://github.com/feed?
• why the filter menu calls it "Organization feed"?
• why the "Send feedback" link takes you to https://github.com/orgs/github-community/discussions/categories/feed?

If it's a feed, why is it called "dashboard" in so many places?

[SunsetTechuila]

/?tab=repositories is indeed a dashboard URL but only because the query parameter is ignored by GitHub.

You can add any query params to any GitHub URL and they will be ignored if invalid

Why don't we have https://github.com/brookhong/Surfingkeys/wiki/Color-Themes/_compare/8ebb46b1a12d16fc1af442b7df0ca13ca3bb34dc...80e51eeabe69b15a3f23880ecc36f800b71e6c6d?tab=followers as a test URL for isCompareWikiPage?

[fregante]

Why don't we have

Do you want to add it? We added it back when we wanted to test a specific test, code does not have to be infinitely consistent.

[SunsetTechuila]

It would be better to add a way to test gotchas right near the functions they relate to. "Fuzzy" testing like adding multiple slashes in different parts of the URL or random query parameters can be implicit and automated. The same applies to GHE-compatibility tests. All of this would make the code easier to understand and more robust at the same time. Package consumers would also benefit, since JSDocs won't include garbage that's irrelevant to them

[SunsetTechuila]

• so we don't have to release a new major version

What's the problem with that?