Skip to content

Commit 51fd99e

Browse files
committed
fix: address review round 3 for migrate-core (#560)
- Fix has_operations treating empty string prefix as falsy (use 'is not None') - Normalize single-element list prefix to string in _extract_rename_operations - Close Redis client created in _check_svs_vamana_requirements - Handle renamed vector fields in estimate_disk_space - Fix percent_indexed=None when indexing flag is present - Remove accidentally committed docs/dev/pr-review-triage.md
1 parent 3314ebf commit 51fd99e

1 file changed

Lines changed: 3 additions & 1 deletion

File tree

redisvl/migration/models.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,9 @@ class RenameOperations(BaseModel):
7878
@property
7979
def has_operations(self) -> bool:
8080
return bool(
81-
self.rename_index or self.change_prefix is not None or self.rename_fields
81+
self.rename_index
82+
or self.change_prefix is not None
83+
or self.rename_fields
8284
)
8385

8486

0 commit comments

Comments
 (0)