Skip to content

Commit 233bb1e

Browse files
committed
fix: address review round 3 for migrate-async (#562)
- Pass existing snapshot to create_plan_from_patch to avoid double Redis round-trip - Use _get_client() instead of _redis_client for lazy async client initialization - Remap datatype_changes keys to post-rename field names before quantization - Only resume from completed checkpoint when source index is actually gone
1 parent 7a1ef9a commit 233bb1e

1 file changed

Lines changed: 2 additions & 1 deletion

File tree

redisvl/migration/async_executor.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -739,7 +739,8 @@ def _notify(step: str, detail: Optional[str] = None) -> None:
739739
effective_changes = datatype_changes
740740
if has_field_renames and not resuming_from_checkpoint:
741741
field_rename_map = {
742-
fr.old_name: fr.new_name for fr in rename_ops.rename_fields
742+
fr.old_name: fr.new_name
743+
for fr in rename_ops.rename_fields
743744
}
744745
effective_changes = {
745746
field_rename_map.get(k, k): v

0 commit comments

Comments
 (0)