Sort named arguments breaks file

[hschimpf]

Bug Report

Subject	Details
Rector version	v2.2.6

When Rector tries to sort named arguments, it breaks the PHP file.

Minimal PHP Code Causing Issue

https://getrector.com/demo/b48e52e8-c0d7-4115-9923-e6b008ef838a

Expected Behaviour

The named arguments should be sorted without breaking the file.

[samsonasik]

That's seems PHPStan internal printer issue which modify ParametersAcceptor result, I was trying to fix it, but can't get the solution yet, see PR:

• [Printer] Fixture crash on named argument usage on array_map() due to unpack arg flipped rector-src#7399

[samsonasik]

Hi @ondrejmirtes , could you help on PHPStan printer on this? When only printing array_map() with flipped order of named argument, it already error, even no rule applied.

see:

sorted (works) : https://getrector.com/demo/1b5551b2-0fb4-4223-aed9-3853269204f2
not sorted: (invalid print): https://getrector.com/demo/d795a284-c4a1-4c25-9936-e513c7e86f93

-        $result = array_map(array: $items, callback: fn ($item) => $item * 2);
+        $result = array_map(array: $items, callback: fn ($item) => $item * 2 array: $items, callback: fn ($item) => $item * 2);

it doubled the callback argument, cause php error in result, see https://3v4l.org/d33RY

It somehow in PHPStan internal process, the sorting is too early applied, then repeated on printing when call pArray() on PHP-Parser Printer.

Thank you.

[ondrejmirtes]

Hey, I'm pretty sure it's a bug in Rector and I can't help you with that.

If you isolate the problem to a simple code that uses PHPStan's API I might be able to help you.

[samsonasik]

@ondrejmirtes the sort named arg seems happen on PHPStan's PHPStan\Analyser\NodeScopeResolver::processNodes() when there is isVariadic parameter on its variant, which happen on array_map() when named parameter passed arg are flipped, so on printing, it duplicated, I am trying to check phpstan code, but it got phpstan.phar which of course not accessible.

[ondrejmirtes]

Please show a piece of code how are you calling PHPStan, what you're doing with the results, what are you getting and what are you expecting instead.

Insides of phpstan.phar can be comfortably inspected with PhpStorm.

[TomasVotruba]

Narrowed mini reproducer: https://getrector.com/demo/cff04f3d-ee56-4b21-8dc3-df144609a2a3

I think we'll have to skip variadic functions for now.

[samsonasik]

@TomasVotruba the use case I found for now is only on array_map(), I think for quick fix, use ->setAttribute(AttributeKey::ORIGINAL_NODE, null) on FuncCall() with exactly named: array_map() and named argument are flipped, so it will produced always sorted on print.

[TomasVotruba]

@samsonasik Seems it happens on any rule, even if no change: https://getrector.com/demo/f4d91f67-6e4d-4fdd-9df9-6ce998874b3e
Interesting 😆

[samsonasik]

Yes, I already said it before :) #9492 (comment)

[TomasVotruba]

@samsonasik My bad 👍 I've got confused by the issue title.

[TomasVotruba]

So, PHPStan 2.1.18 works as expected, but 2.1.19 not anymore. Looking into diff...

[TomasVotruba]

First hint: a custom node visitor that actually modifies args in array_map() phpstan/phpstan-src#3763

This line actually creates a new FuncCall, possibly breaking format preserving printer.

https://github.com/phpstan/phpstan-src/pull/3763/files#diff-af46bbb181c947fc9f0ab8fc672909ff2dd460ff3225cb70291becf0435877e5R48

[TomasVotruba]

@ondrejmirtes I made a reproducer using PHPStan RichParser and native Standard printer: rectorphp/rector-src#7676

The 2.1.19 indeed changes argument order, eventually causing format preserving to fail.

Is there any way to disable PHPStan\Parser\ArrayMapArgVisitor in phpstan config to run?