Cannot redeclare function isPHPStanTestPreloaded fatal error on Rector 2.2.2

[X-Coder264]

Bug Report

Subject	Details
Rector version	2.2.2

I use PHPUnit 12.4.1. With Rector 2.2.1 I didn't have any problems. After updating to 2.2.2 whenever I try to run a PHPUnit test it fails with the PHP Fatal error: Cannot redeclare function isPHPStanTestPreloaded() (previously declared in /app/vendor/rector/rector/preload.php:19) message.

[TomasVotruba]

Hi, thanks for reporting.
This might be challenge to tackle. Can you create minimal reproducer repository on GitHub?
What OS do you use?

[samsonasik]

@TomasVotruba function_exists() seems needed before define the isPHPStanTestPreloaded() function, multiple autoload may cause this, or use of require instead of require_once

[TomasVotruba]

@samsonasik We'll need a failing test case in https://github.com/rectorphp/rector-compat-tests first. I want to be sure we know the cause

[samsonasik]

@TomasVotruba yes, that's the ideal way 👍

I created PR for this patch tho

• Handle crash redeclare isPHPStanTestPreloaded() function rector-src#7460

so @X-Coder264 can verify it.

[samsonasik]

@TomasVotruba I create alternative PR as well:

• [Alternative] Use direct check to avoid redeclare function isPHPStanTestPreloaded() rector-src#7461

[TomasVotruba]

@samsonasik Let's isolate the issue first.

@X-Coder264 Can you share a reproducer repository?

[samsonasik]

@X-Coder264 the possible issue is you're using include instead of include_once, I can reproduce it with custom phpunit bootstrap somewhere, reproduced with:

<?php

include __DIR__ . '/../../../../vendor/rector/rector/preload.php';
include __DIR__ . '/../../../../vendor/autoload.php';

It is recommended to use require_once over require or 'include` so it verify it already included once, no need to re-include.

@TomasVotruba I created PR

• Add test to reproduce cannot redeclare isPHPStanTestPreloaded() rector-compat-tests#1

for it.

[AtCliffUnderline]

Faced same issue when trying to run PHPUnit

[samsonasik]

@AtCliffUnderline please provide reproducible test repo if possible, also check my suggestion to only use require_once or include_once to ensure no double include.

Also, try "rector/rector": "dev-main" :)

[samsonasik]

Rector 2.2.3 just released https://github.com/rectorphp/rector/releases/tag/2.2.3

also verify if you have magic require over require_once usage on autoload use.

[LordSimal]

We also encountered this issue with our cakephp/upgrade 5.x testsuite.

If you want to reproduce it (yes, its not minimal 😅 ) you can check that repo out, do a make install-dev and then run composer test

EDIT: Actually I just found it.
Previously we had this line in our tests/bootstrap.php:

require dirname(__DIR__) . '/vendor/rector/rector/preload.php';

because it was required for rector to run in testsuite (I guess)

But now its not needed anymore.