System error: "strtolower() expects parameter 1 to be string, bool given

[JoshuaEstes]

Bug Report

Subject	Details
Rector version	2.2.0
PHP Version	7.4.33

When running rector on a file, I will get the error:

[ERROR] Could not process "/path/to/file.php" file, due to:                                                                               11:51:04 [93/4883]
         "System error: "strtolower() expects parameter 1 to be string, bool given"

         Stack trace:
         #0
         tools/rector/vendor/rector/rector/rules/CodingStyle/ClassNameImport/ClassNameImportSkipVoter/ClassLikeNameClassNameImportSkipVoter.php(48): strtolower()
         #1 tools/rector/vendor/rector/rector/rules/CodingStyle/ClassNameImport/ClassNameImportSkipper.php(39):
         Rector\CodingStyle\ClassNameImport\ClassNameImportSkipVoter\ClassLikeNameClassNameImportSkipVoter->shouldSkip(
         )
         #2 tools/rector/vendor/rector/rector/rules/CodingStyle/Node/NameImporter.php(94):
         Rector\CodingStyle\ClassNameImport\ClassNameImportSkipper->shouldSkipNameForFullyQualifiedObjectType()
         #3 tools/rector/vendor/rector/rector/rules/CodingStyle/Node/NameImporter.php(55):
         Rector\CodingStyle\Node\NameImporter->importNameAndCollectNewUseStatement()
         #4 tools/rector/vendor/rector/rector/src/PostRector/Rector/NameImportingPostRector.php(52):
         Rector\CodingStyle\Node\NameImporter->importName()

NOTE: The above has been trimmed

Minimal PHP Code Causing Issue

Not able to reproduce the issue there. I did notice that when getClassName and getShortName are the same, this is where it will have a fatal error. Not sure how it gets those, but I can tell you that the name giving me issues is Exception.

Expected Behaviour

Not crash ;p

[TomasVotruba]

Thank you for your report!

We'll need an isolated failing demo link from: http://getrector.com/demo,
that way we can reproduce the bug.

[samsonasik]

@TomasVotruba this happen on php 7.x, I will look into it

[samsonasik]

Fixed and released 2.2.1 for it

https://github.com/rectorphp/rector/releases/tag/2.2.1

[simonschaufi]

The problem is that rector source has no tests for php 7.4, so this can't be covered with tests 😢
Thanks for the fix and the new release!

[samsonasik]

we have e2e directory on scoped build as well that test on php 7.x

https://github.com/rectorphp/rector/tree/main/e2e

that can be added later for this use case, I was just make quick fix :)

[JoshuaEstes]

That was quick, thank you!

[TomasVotruba]

I've reviewed the fix and it seems wrong. We should not blindly add casting to single place without understanding.
We'll need a test fixture that is causing it, so we never let invalid value in 👍

@JoshuaEstes Could you share more detailed about code that is causing this? Ideally demo link http://getrector.com/demo

[samsonasik]

@TomasVotruba should be this example as short name == full class name https://getrector.com/demo/8ed4f981-10db-4276-8c8a-edbcd3ff26c5

see php 7.4 demo https://3v4l.org/WJ5Id#v7.4.33

[TomasVotruba]

I see. I think the code should not use -1, but use ltrim('\\') to remove the slashes. That way it works.

See https://3v4l.org/5WRb9#v7.4.33