Remove unused import remove a used symbol

[theofidry]

Bug Report

Subject	Details
Rector version	fe7432

Under some circumstances, Rector removes an import statement for a used symbol.

Minimal PHP Code Causing Issue

https://getrector.com/demo/6a604453-8149-4f01-a244-d4553ed0d41c

Expected Behaviour

The use App\Entity; should not be moved.

---

This seems to be due to the usage of both the phpdoc and the attribute. When the attribute is not present Rector doesn't remove this use statement.

[TomasVotruba]

Just quickly scanning the demo.... I think that's correct, as there are 2 comment lines. php-parser takes the first one above the class method.

If the attribute is moved is to the correct place, it works as expected:
https://getrector.com/demo/23358a90-22e5-4321-ba6b-1358c1075da9

[samsonasik]

That is expected, comment should be before attribute , see https://getrector.com/demo/0ad82c94-f2f9-49be-ba9e-d3847ed945fb

[calebdw]

See also: phpstan/phpstan-src#4101

[theofidry]

comment should be before attribute

Why is that? It seems to be an arbitrary rule. The PHP engine does not care, neither do some static analysers (like the IDE itself, however limited it is compared to one by PHPStan).

@calebdw also reported the issue in PHPStan and AFAIU it is considered an active bug, rather than the expected behaviour.

edit: thanks for sharing a way it works though, it's a bit annoying as it means it is something we need to keep a closer eye on but it's better than ignoring this rule or file!