Broken diff output in v2.1.3

[ericwoelki]

Bug Report

Subject	Details
Rector version	v2.1.3

Minimal PHP Code Causing Issue

Looks like this in v2.1.3

Expected Behaviour

Looked like this in v2.1.2

[samsonasik]

Could you provide reproducible at https://getrector.com/demo ? Better to add failing test case on target rules-tests on rector-src.

Thank you.

[ericwoelki]

Not sure it'll help much but: https://getrector.com/demo/79ce419d-a8e6-47ad-8146-17850f3de34c

The code is being changed correctly, it's just the console output which is messed up. It doesn't seem specific to that rule either; seems to be the console output for the diff of changes from any rule.

[samsonasik]

Ok, I can reproduce on windows:

$ vendor/bin/rector process foo.php --dry-run
 1/1 [============================] 100%
1 file with changes
===================

1) foo.php:1

    ---------- begin diff ----------
<@ @@< <?php

<fg=ction foo() {</fg=gtion foo(): void {</fg=ho 'hello world';
 }
<comment------- end diff -----------</commen
Applied rules:
 * AddFunctionVoidReturnTypeWhereNoReturnRector



 [OK] 1 file would have been changed (dry-run) by Rector

it probably some dependency cause this, eg; sebastianbergmann/diff or symfony/console,

It will take time, but i will look into it. feel free to provide a patch if you're faster than me :)

[samsonasik]

/cc @staabm @paulbalandan could you help on this?

it only happen on windows, probably some dependency cause this, eg; sebastianbergmann/diff or symfony/console that have latest release on the 1 month range.

Thank you

[samsonasik]

Ok, it seems due to symfony/console 6.4.24, pin to 6.4.23 working ok, see:

symfony/console 6.4.24

Pin to symfony/console 6.4.23

[samsonasik]

I open an issue on symfony/symfony repo:

• symfony/console 6.4.24 cause printed <fg> on windows symfony/symfony#61429

[samsonasik]

I got the solution, remove vendor patch for symfony/console helper resolve it, see PR:

• [Console] Fix symfony/console diff broken on windows on symfony/console 6.4.24 rector-src#7148

[samsonasik]

That should already resolved at PR:

• [Console] Fix symfony/console diff broken on windows on symfony/console 6.4.24 rector-src#7148

Please try latest dev-main

composer config minimum-stability dev
composer config prefer-stable true
composer update rector/rector:dev-main

[samsonasik]

@ericwoelki immediate Rector 2.1.4 released for it :) https://github.com/rectorphp/rector/releases/tag/2.1.4