Add rector to convert assigns to named arguments

[calebdw]

Feature Request

Hello!

We have a bunch of legacy code that uses assignments to indicate the parameter name (the created variable is not used in the rest of the scope). For PHP 8+, this can be converted to using named arguments.

If such a rector does not yet exist then I will start working on one if this is desired.

Diff

-in_array('foo', $array, $strict = true);
+in_array('foo', $array, strict: true);

Thanks!

[calebdw]

@samsonasik, if I'm targeting CallLike nodes (func, method, static), how can I get information about the parent node/scope? I need to check if the variable is used in the rest of the scope.

Is that possible or do I need to target the nodes with stmts like class, function, etc?

[samsonasik]

scope->hasVariableType(variablename) should can verify if variable exists.

[calebdw]

But it needs to be in the next stmt not the current statement

[samsonasik]

You can check existing rules that check variable used, eg

https://github.com/rectorphp/rector-src/blob/65e3739ad8cda12d03b4abbf7f659fb8ea506d0d/rules/DeadCode/Rector/For_/RemoveDeadIfForeachForRector.php#L148-L153

[samsonasik]

Assign doesn't necessarily to be a named argument, see https://3v4l.org/9ePXj

And per discussion at rectorphp/rector-src#7133 , this seems very niche usage :)

I am closing it.

[github-actions]

This issue has been automatically locked because it has been closed for 150 days. Please open a new issue if you have a similar problem.