-
Notifications
You must be signed in to change notification settings - Fork 65
Expand file tree
/
Copy pathAssertFuncCallToPHPUnitAssertRector.php
More file actions
173 lines (146 loc) · 5.21 KB
/
AssertFuncCallToPHPUnitAssertRector.php
File metadata and controls
173 lines (146 loc) · 5.21 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
<?php
declare(strict_types=1);
namespace Rector\PHPUnit\CodeQuality\Rector\FuncCall;
use PhpParser\Node;
use PhpParser\Node\Arg;
use PhpParser\Node\Expr;
use PhpParser\Node\Expr\BinaryOp\Equal;
use PhpParser\Node\Expr\BinaryOp\Identical;
use PhpParser\Node\Expr\BinaryOp\NotIdentical;
use PhpParser\Node\Expr\Cast\Bool_;
use PhpParser\Node\Expr\ClassConstFetch;
use PhpParser\Node\Expr\FuncCall;
use PhpParser\Node\Expr\Instanceof_;
use PhpParser\Node\Expr\MethodCall;
use PhpParser\Node\Expr\StaticCall;
use PhpParser\Node\Expr\Variable;
use PhpParser\Node\Name\FullyQualified;
use PHPStan\Reflection\ClassReflection;
use Rector\PhpParser\Node\Value\ValueResolver;
use Rector\PHPStan\ScopeFetcher;
use Rector\PHPUnit\Enum\AssertMethod;
use Rector\PHPUnit\Enum\PHPUnitClassName;
use Rector\Rector\AbstractRector;
use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
/**
* @see \Rector\PHPUnit\Tests\CodeQuality\Rector\FuncCall\AssertFuncCallToPHPUnitAssertRector\AssertFuncCallToPHPUnitAssertRectorTest
*/
final class AssertFuncCallToPHPUnitAssertRector extends AbstractRector
{
public function __construct(
private readonly ValueResolver $valueResolver
) {
}
public function getRuleDefinition(): RuleDefinition
{
return new RuleDefinition('Turns assert() calls to their explicit PHPUnit assert alternative', [
new CodeSample('assert($value === 100, "message");', '$this->assertSame(100, $value, "message");'),
]);
}
/**
* @return class-string[]
*/
public function getNodeTypes(): array
{
return [FuncCall::class];
}
/**
* @param FuncCall $node
*/
public function refactor(Node $node): StaticCall|MethodCall|null
{
if ($node->isFirstClassCallable()) {
return null;
}
if (! $this->isName($node, 'assert')) {
return null;
}
if (! $this->isTestFilePath($node) && ! $this->isBehatContext($node)) {
return null;
}
$comparedExpr = $node->getArgs()[0]
->value;
if ($comparedExpr instanceof Equal) {
$methodName = AssertMethod::ASSERT_EQUALS;
$exprs = [$comparedExpr->right, $comparedExpr->left];
} elseif ($comparedExpr instanceof Identical) {
$methodName = AssertMethod::ASSERT_SAME;
$exprs = [$comparedExpr->right, $comparedExpr->left];
} elseif ($comparedExpr instanceof NotIdentical) {
if ($this->valueResolver->isNull($comparedExpr->right)) {
$methodName = 'assertNotNull';
$exprs = [$comparedExpr->left];
} else {
return null;
}
} elseif ($comparedExpr instanceof Bool_) {
$methodName = 'assertTrue';
$exprs = [$comparedExpr];
} elseif ($comparedExpr instanceof FuncCall) {
if ($this->isName($comparedExpr, 'method_exists')) {
$methodName = 'assertTrue';
$exprs = [$comparedExpr];
} else {
return null;
}
} elseif ($comparedExpr instanceof Instanceof_) {
// outside TestCase
$methodName = 'assertInstanceOf';
$exprs = [];
if ($comparedExpr->class instanceof FullyQualified) {
$classConstFetch = new ClassConstFetch($comparedExpr->class, 'class');
$exprs[] = $classConstFetch;
} else {
return null;
}
$exprs[] = $comparedExpr->expr;
} else {
return null;
}
// is there a comment message
if (isset($node->getArgs()[1])) {
$exprs[] = $node->getArgs()[1]->value;
}
return $this->createCall($node, $methodName, $exprs);
}
private function isBehatContext(FuncCall $funcCall): bool
{
$scope = ScopeFetcher::fetch($funcCall);
if (! $scope->getClassReflection() instanceof ClassReflection) {
return false;
}
$className = $scope->getClassReflection()
->getName();
// special case with static call
return str_ends_with($className, 'Context');
}
private function isTestFilePath(FuncCall $funcCall): bool
{
$scope = ScopeFetcher::fetch($funcCall);
if (! $scope->getClassReflection() instanceof ClassReflection) {
return false;
}
$className = $scope->getClassReflection()
->getName();
if (str_ends_with($className, 'Test')) {
return true;
}
return str_ends_with($className, 'TestCase');
}
/**
* @param Expr[] $exprs
*/
private function createCall(FuncCall $funcCall, string $methodName, array $exprs): MethodCall|StaticCall
{
$args = [];
foreach ($exprs as $expr) {
$args[] = new Arg($expr);
}
if ($this->isBehatContext($funcCall)) {
$assertFullyQualified = new FullyQualified(PHPUnitClassName::ASSERT);
return new StaticCall($assertFullyQualified, $methodName, $args);
}
return new MethodCall(new Variable('this'), $methodName, $args);
}
}