[Performance] Use spl_object_id() when possible

samsonasik · samsonasik · commit 695b669f6159 · 2023-09-05T02:41:11.000+07:00
diff --git a/src/Timer/Timers.php b/src/Timer/Timers.php
@@ -38,7 +38,7 @@ public function getTime()
 
     public function add(TimerInterface $timer)
     {
-        $id = \spl_object_hash($timer);
+        $id = \PHP_VERSION_ID < 70200 ? \spl_object_hash($timer) : \spl_object_id($timer);
         $this->timers[$id] = $timer;
         $this->schedule[$id] = $timer->getInterval() + $this->updateTime();
         $this->sorted = false;
@@ -51,7 +51,7 @@ public function contains(TimerInterface $timer)
 
     public function cancel(TimerInterface $timer)
     {
-        $id = \spl_object_hash($timer);
+        $id = \PHP_VERSION_ID < 70200 ? \spl_object_hash($timer) : \spl_object_id($timer);
         unset($this->timers[$id], $this->schedule[$id]);
     }
 

Original file line number	Diff line number	Diff line change
`@@ -38,7 +38,7 @@ public function getTime()`
`38`	`38`
`39`	`39`	`public function add(TimerInterface $timer)`
`40`	`40`	`{`
`41`		`- $id = \spl_object_hash($timer);`
	`41`	`+ $id = \PHP_VERSION_ID < 70200 ? \spl_object_hash($timer) : \spl_object_id($timer);`
`42`	`42`	`$this->timers[$id] = $timer;`
`43`	`43`	`$this->schedule[$id] = $timer->getInterval() + $this->updateTime();`
`44`	`44`	`$this->sorted = false;`
`@@ -51,7 +51,7 @@ public function contains(TimerInterface $timer)`
`51`	`51`
`52`	`52`	`public function cancel(TimerInterface $timer)`
`53`	`53`	`{`
`54`		`- $id = \spl_object_hash($timer);`
	`54`	`+ $id = \PHP_VERSION_ID < 70200 ? \spl_object_hash($timer) : \spl_object_id($timer);`
`55`	`55`	`unset($this->timers[$id], $this->schedule[$id]);`
`56`	`56`	`}`
`57`	`57`