get offline=FALSE working again

Author: timelyportfolio

R/dependencies.R

@@ -12,7 +12,7 @@
 #' library(reactR)
 #' library(htmltools)
 #'
-#' attachDependencies(
+#' tagList(
 #'   tags$script(
 #'   "
 #'     ReactDOM.render(
@@ -25,7 +25,7 @@
 #'     )
 #'   "
 #'   ),
-#'   html_dependency_react()
+#'   html_dependency_react() #offline=FALSE for CDN
 #' )
 html_dependency_react <- function(offline=TRUE){
   hd <- htmltools::htmlDependency(
@@ -36,11 +36,12 @@ html_dependency_react <- function(offline=TRUE){
   )
 
   if(!offline) {
-    hd$src <- list(href=sprintf(
-      "//unpkg.com/react/@%s/",
-      react_version()
-    ))
-    hd$script = c("react.production.min.js", "react-dom.production.min.js")
+    hd$src <- list(href="//unpkg.com")
+
+    hd$script <- c(
+      "react/umd/react.production.min.js",
+      "react-dom/umd/react-dom.production.min.js"
+    )
   }
 
   hd

docs/articles/index.html

@@ -14,10 +14,11 @@ blueprint <- htmlDependency(
 
 # make sure we have dependencies as expected
 #  by adding react and blueprint to empty tagList
-tagList() %>>%
-  attachDependencies(
-    list(html_dependency_react(offline=FALSE), blueprint)
-  ) %>>%
+tagList(
+  html_dependency_react(offline=FALSE),
+  html_dependency_reactdom(offline=FALSE),
+  blueprint
+) %>>%
   browsable()
 
 
@@ -55,20 +56,17 @@ ReactDOM.render(tbl, document.querySelector("#app-table"));
         )
       )
     )
-  )
-)%>>%
-  attachDependencies(
-    list(
-      htmlDependency(
-        name="classnames",
-        version="2.2.5",
-        src = c(href="https://unpkg.com/classnames"),
-        script = ""
-      ),
-      html_dependency_react(offline=FALSE),
-      blueprint
-    )
-  ) %>>%
+  ),
+  htmlDependency(
+    name="classnames",
+    version="2.2.5",
+    src = c(href="https://unpkg.com/classnames"),
+    script = ""
+  ),
+  html_dependency_react(),
+  html_dependency_reactdom(),
+  blueprint
+) %>>%
   browsable()
 
 
@@ -93,18 +91,15 @@ ReactDOM.render(tbl, document.querySelector('#app-table'));
 
       )
     )
-)
-)%>>%
-  attachDependencies(
-    list(
-      htmlDependency(
-        name="classnames",
-        version="2.2.5",
-        src = c(href="https://unpkg.com/classnames"),
-        script = ""
-      ),
-      html_dependency_react(offline=FALSE),
-      blueprint
-    )
-  ) %>>%
+  ),
+  htmlDependency(
+    name="classnames",
+    version="2.2.5",
+    src = c(href="https://unpkg.com/classnames"),
+    script = ""
+  ),
+  html_dependency_react(),
+  html_dependency_reactdom(),
+  blueprint
+) %>>%
   browsable()