-
Notifications
You must be signed in to change notification settings - Fork 43
Open
Description
Context
Once the backend RPCs from #1459 and #1461 are implemented, both SDKs need to stop using policy RPCs (listPolicies, deletePolicy, createPolicy, createPolicyForProject) for member management and switch to the new role-based RPCs.
React SDK changes
| File | Current | Replace with |
|---|---|---|
web/sdk/react/views/members/member-columns.tsx |
listPolicies → deletePolicy x N → createPolicy |
SetOrganizationMemberRole |
web/sdk/react/views/projects/details/project-member-columns.tsx |
listPolicies → deletePolicy x N → createPolicy |
SetProjectMemberRole |
web/sdk/react/views/projects/details/project-members.tsx |
createPolicyForProject |
SetProjectMemberRole |
web/sdk/react/views/projects/details/remove-project-member-dialog.tsx |
listPolicies → deletePolicy x N |
RemoveProjectMember |
web/sdk/react/views/api-keys/list/add-service-account-dialog.tsx |
createPolicyForProject |
SetProjectMemberRole |
web/sdk/react/views/api-keys/details/manage-service-user-projects-dialog.tsx |
createPolicyForProject / listPolicies → deletePolicy x N |
SetProjectMemberRole / RemoveProjectMember |
Admin SDK changes
| File | Current | Replace with |
|---|---|---|
web/sdk/admin/components/AssignRole.tsx |
listPolicies → deletePolicy x N → createPolicy x N |
SetOrganizationMemberRole |
web/sdk/admin/views/organizations/details/projects/members/assign-role.tsx |
listPolicies → deletePolicy x N → createPolicy x N |
SetProjectMemberRole |
web/sdk/admin/views/organizations/details/projects/members/remove-member.tsx |
listPolicies → deletePolicy x N |
RemoveProjectMember |
web/sdk/admin/views/organizations/details/projects/use-add-project-members.tsx |
createPolicy |
SetProjectMemberRole |
Additional SDK fixes
- Gate org role-change UI on
policymanageinstead ofupdate(or align backend to checkupdate) - Refresh permissions after role changes (currently checked once on page load)
- Org members page: call
listOrganizationRolesalongsidelistRolesso custom org roles appear in the role-change dropdown
Depends on
- Add SetOrganizationMemberRole RPC to replace client-side policy manipulation #1459 —
SetOrganizationMemberRolebackend RPC - Add high-level RPCs for project member management to remove client-side policy manipulation #1461 —
SetProjectMemberRoleandRemoveProjectMemberbackend RPCs
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels