fix(undersync-switch): adjust inputs and document the flow inputs

Adjust the inputs to be displayed and document what they actually are
and consume them from the inputs so that in the logging it shows how all
the arguments were passed in.

Author: cardoe

charts/site-workflows/templates/sensor-ironic-port-delete.yaml

@@ -62,9 +62,9 @@ spec:
                   parameters:
                     - name: physical_network
                     - name: force
-                      value: false
+                      value: "false"
                     - name: dry_run
-                      value: false
+                      value: "false"
                 # references the workflow
                 workflowTemplateRef:
                   name: undersync-switch

workflows/argo-events/workflowtemplates/undersync-switch.yaml

@@ -4,24 +4,60 @@ metadata:
   annotations:
     workflows.argoproj.io/title: Requests an Undersync run on a pair of switches
     workflows.argoproj.io/description: |
+      Requests an Undersync run for a switch pair identified by `physical_network`.
+
+      Parameters:
+
+      - `physical_network`: required switch pair / physical network identifier
+      - `force`: rerun even if Undersync believes the switch is already in the desired state
+      - `dry_run`: show the intended changes without applying them
+
+      To test this workflow you can run it with the following:
+
+      ```
+      argo -n argo-events submit --from workflowtemplate/undersync-switch \
+        -p physical_network=physnet1 -p force=false -p dry_run=false
+      ```
+
       Defined in `workflows/argo-events/workflowtemplates/undersync-switch.yaml`
 kind: WorkflowTemplate
 spec:
   entrypoint: undersync-switch
   serviceAccountName: workflow
+  arguments:
+    parameters:
+      - name: physical_network
+        description: Physical network or switch pair to run Undersync against.
+      - name: force
+        description: Force reconciliation even when the current state appears correct.
+        default: "false"
+        enum:
+          - "true"
+          - "false"
+      - name: dry_run
+        description: Preview the changes without making any updates.
+        default: "false"
+        enum:
+          - "true"
+          - "false"
   templates:
     - name: undersync-switch
+      inputs:
+        parameters:
+          - name: physical_network
+          - name: force
+          - name: dry_run
       container:
         image: ghcr.io/rackerlabs/understack/ironic-nautobot-client:latest
         command:
           - undersync-switch
         args:
           - --physical-network
-          - "{{workflow.parameters.physical_network}}"
+          - "{{inputs.parameters.physical_network}}"
           - --dry-run
-          - "{{workflow.parameters.dry_run}}"
+          - "{{inputs.parameters.dry_run}}"
           - --force
-          - "{{workflow.parameters.force}}"
+          - "{{inputs.parameters.force}}"
         volumeMounts:
           - mountPath: /etc/nb-token/
             name: nb-token
@@ -35,11 +71,6 @@ spec:
               secretKeyRef:
                 name: nautobot-token
                 key: url
-      inputs:
-        parameters:
-          - name: physical_network
-          - name: force
-          - name: dry_run
       volumes:
         - name: nb-token
           secret: