Fix flaky test

Author: guilload

quickwit/quickwit-ingest/src/ingest_v2/idle.rs

@@ -89,7 +89,7 @@ mod tests {
     async fn test_close_idle_shards_run() {
         let (_temp_dir, state) = IngesterState::for_test().await;
         let weak_state = state.weak();
-        let idle_shard_timeout = Duration::from_millis(200);
+        let idle_shard_timeout = RUN_INTERVAL_PERIOD * 4;
         let join_handle = CloseIdleShardsTask::spawn(weak_state, idle_shard_timeout);
 
         let mut state_guard = state.lock_partially().await.unwrap();
@@ -111,7 +111,6 @@ mod tests {
             "test-source".to_string(),
             ShardId::from(2),
         )
-        .with_last_write(now - idle_shard_timeout / 2)
         .build();
         let queue_id_02 = shard_02.queue_id();
         state_guard.shards.insert(queue_id_02.clone(), shard_02);

quickwit/quickwit-ingest/src/ingest_v2/state.rs

@@ -83,16 +83,9 @@ impl InnerIngesterState {
             .filter(|shard| {
                 shard.is_open() && shard.index_uid == *index_uid && shard.source_id == *source_id
             })
-            // We use reduce here because we need a mutable borrow of the shard, since
-            // available_permits() calls refill, which is a mutator.
-            .reduce(|best, current| {
-                if current.rate_limiter.available_permits() > best.rate_limiter.available_permits()
-                {
-                    current
-                } else {
-                    best
-                }
-            })
+            .map(|shard| (shard.rate_limiter.available_permits(), shard))
+            .max_by_key(|(available_permits, _)| *available_permits)
+            .map(|(_, shard)| shard)
     }
 }