Skip to content

Commit 32241a2

Browse files
committed
Added comments about not performing request validation on error pages.
1 parent f1807a3 commit 32241a2

File tree

2 files changed

+10
-2
lines changed

2 files changed

+10
-2
lines changed

QueueIT.Security.Examples/web/error.jsp

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,10 @@
33
<%@page contentType="text/html" pageEncoding="UTF-8"%>
44
<%@taglib prefix="t" tagdir="/WEB-INF/tags" %>
55
<%
6-
String queueName = request.getParameter("queuename");
6+
// IMPORTANT !
7+
// Never call request validation from error handling pages (e.g. error.jsp) which will cause users to get looped arround.
8+
9+
String queueName = request.getParameter("queuename");
710
URI targetUrl = new URI(request.getParameter("t"));
811
IQueue queue = QueueFactory.createQueue(queueName);
912
String cancelUrl = queue.getCancelUrl(targetUrl).toString();

QueueIT.Security/src/queueit/security/SessionValidationController.java

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,12 @@
99

1010
public class SessionValidationController {
1111

12-
private static int defaultTicketExpiration = 0;
12+
13+
// IMPORTANT !
14+
// Never call request validation from error handling pages (e.g. error.jsp) which will cause users to get looped arround.
15+
16+
17+
private static int defaultTicketExpiration = 0;
1318
private static IValidateResultRepository defaultValidationResultRepository = new CookieValidateResultRepository();
1419
private static Callable<IValidateResultRepository> defaultValidationResultProviderFactory = new Callable<IValidateResultRepository>() {
1520
public IValidateResultRepository call() {

0 commit comments

Comments
 (0)