Skip to content
This repository was archived by the owner on May 3, 2019. It is now read-only.
This repository was archived by the owner on May 3, 2019. It is now read-only.

Handle light vs deep integration of Electron #6

@zuck

Description

@zuck

With the current implementation of electron-wrapper, launching the command quasar wrap electron simply creates a project structure to launch an Electron shell and executing the packaged application inside of it without deep integration (no access to Electron's renderer API).

I imagine two ways to solve this issue:

  1. Add option to set light vs deep Electron integration to quasar wrap electron command (quasar wrap electron --deep/light).
  2. Make quasar dev/build commands on project root folder (not electron/) more explicit, in order to better handle Electron integration (quasar dev/build electron --deep/light instead of previous quasar dev)

In both cases, with deep integration I mean changing or adding to the webpack conf the target electron-renderer and electron package in dependencies inside package.json of root project. With light integration I mean the current mode (just Electron shell executing an URL without accessing to Electron API).

My personal choice would be no.2, because it should allow us to change dynamically the webpack config to handle both cases without changing code, so that the same codebase could be used for browser (quasar dev/build), Electron (quasar dev/build electron) or Cordova (quasar dev/build cordova).

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions