refactor: 전반적인 테스트 리펙토링

Author: MU-Software

app/admin_api/test/shop/conftest.py

@@ -2,25 +2,19 @@
 from notification.models import EmailNotificationTemplate
 from shop.conftest import (  # noqa: F401
     anon_client,
-    completed_order,
     customer_client,
-    donation_completed_order,
     donation_product,
-    donation_refunded_order,
-    empty_cart,
     mock_portone_kcp_receipt,
     mock_portone_register,
     mock_portone_req_cancel_payment,
     modifiable_option_relation,
     option,
     option_group,
+    order_factory,
     other_client,
     other_user,
-    partial_refunded_order,
-    pending_order,
     product,
     products_by_status,
-    refunded_order,
     single_product_cart,
     staff_client,
     staff_user,

app/admin_api/test/shop/order_notifications_api_test.py

@@ -21,7 +21,8 @@ def test_notification_send_rejects_non_superuser(customer_client):
 
 
 @pytest.mark.django_db
-def test_notification_preview_returns_recipients_for_completed_order(api_client, completed_order, order_email_template):
+def test_notification_preview_returns_recipients_for_completed_order(api_client, order_email_template, order_factory):
+    completed_order = order_factory(status="completed")
     response = OrderNotificationsAdminApi(http_client=api_client).preview(
         {"channel": "email", "template_id": str(order_email_template.id)}
     )
@@ -50,7 +51,8 @@ def test_notification_preview_returns_recipients_for_completed_order(api_client,
 
 
 @pytest.mark.django_db
-def test_notification_preview_rejects_unknown_template_id(api_client, completed_order):
+def test_notification_preview_rejects_unknown_template_id(api_client, order_factory):
+    order_factory(status="completed")
     response = OrderNotificationsAdminApi(http_client=api_client).preview(
         {"channel": "email", "template_id": "00000000-0000-0000-0000-000000000000"}
     )
@@ -62,7 +64,8 @@ def test_notification_preview_rejects_unknown_template_id(api_client, completed_
 
 
 @pytest.mark.django_db
-def test_notification_preview_excludes_refunded_orders(api_client, refunded_order, order_email_template):
+def test_notification_preview_excludes_refunded_orders(api_client, order_email_template, order_factory):
+    order_factory(status="refunded")
     response = OrderNotificationsAdminApi(http_client=api_client).preview(
         {"channel": "email", "template_id": str(order_email_template.id)}
     )
@@ -74,8 +77,8 @@ def test_notification_preview_excludes_refunded_orders(api_client, refunded_orde
 
 
 @pytest.mark.django_db
-def test_notification_send_creates_history_for_completed_order(api_client, completed_order, order_email_template):
-    # order_email_template 의 모든 변수가 Order 에서 자동 추출되므로 context_override 불필요.
+def test_notification_send_creates_history_for_completed_order(api_client, order_email_template, order_factory):
+    order_factory(status="completed")
     response = OrderNotificationsAdminApi(http_client=api_client).send(
         {"channel": "email", "template_id": str(order_email_template.id)}
     )
@@ -90,8 +93,8 @@ def test_notification_send_creates_history_for_completed_order(api_client, compl
 
 
 @pytest.mark.django_db
-def test_notification_preview_skips_order_without_customer_info(api_client, completed_order, order_email_template):
-    # hard_delete 로 reverse OneToOne 부재 → to_representation 의 customer_info guard 가 None 반환.
+def test_notification_preview_skips_order_without_customer_info(api_client, order_email_template, order_factory):
+    completed_order = order_factory(status="completed")
     CustomerInfo.objects.filter(order=completed_order).hard_delete()
     response = OrderNotificationsAdminApi(http_client=api_client).preview(
         {"channel": "email", "template_id": str(order_email_template.id)}
@@ -101,7 +104,8 @@ def test_notification_preview_skips_order_without_customer_info(api_client, comp
 
 
 @pytest.mark.django_db
-def test_notification_preview_skips_order_with_empty_recipient_field(api_client, completed_order, order_email_template):
+def test_notification_preview_skips_order_with_empty_recipient_field(api_client, order_email_template, order_factory):
+    completed_order = order_factory(status="completed")
     completed_order.customer_info.email = ""
     completed_order.customer_info.save()
     response = OrderNotificationsAdminApi(http_client=api_client).preview(
@@ -112,8 +116,8 @@ def test_notification_preview_skips_order_with_empty_recipient_field(api_client,
 
 
 @pytest.mark.django_db
-def test_notification_preview_skips_order_with_no_active_products(api_client, completed_order, order_email_template):
-    # OPR soft-delete → admin queryset 의 products prefetch (filter_active) 가 제외 → next() 가 None.
+def test_notification_preview_skips_order_with_no_active_products(api_client, order_email_template, order_factory):
+    completed_order = order_factory(status="completed")
     completed_order.products.first().delete()
     response = OrderNotificationsAdminApi(http_client=api_client).preview(
         {"channel": "email", "template_id": str(order_email_template.id)}
@@ -123,8 +127,8 @@ def test_notification_preview_skips_order_with_no_active_products(api_client, co
 
 
 @pytest.mark.django_db
-def test_notification_send_rejects_when_no_eligible_recipients(api_client, completed_order, order_email_template):
-    # 모든 매칭 order 가 customer_info 부재 → items=[] → "발송 대상이 없습니다" 400.
+def test_notification_send_rejects_when_no_eligible_recipients(api_client, order_email_template, order_factory):
+    completed_order = order_factory(status="completed")
     CustomerInfo.objects.filter(order=completed_order).hard_delete()
     response = OrderNotificationsAdminApi(http_client=api_client).send(
         {"channel": "email", "template_id": str(order_email_template.id)}
@@ -135,9 +139,9 @@ def test_notification_send_rejects_when_no_eligible_recipients(api_client, compl
 
 @pytest.mark.django_db
 def test_notification_send_rejects_when_recipients_have_missing_template_variables(
-    api_client, completed_order, superuser
+    api_client, superuser, order_factory
 ):
-    # Order 에서 추출되지 않는 변수 (`coupon_code`) 를 요구하는 템플릿 → missing_variables 발생 → 400.
+    order_factory(status="completed")
     template = EmailNotificationTemplate.objects.create(
         code="coupon",
         title="쿠폰",

app/admin_api/test/shop/orders_api_test.py

@@ -28,7 +28,9 @@ def test_admin_list_rejects_non_superuser_client(request, client_fixture):
 
 
 @pytest.mark.django_db
-def test_admin_list_returns_only_orders_with_payment_history_and_products(api_client, completed_order, empty_cart):
+def test_admin_list_returns_only_orders_with_payment_history_and_products(api_client, order_factory):
+    completed_order = order_factory(status="completed")
+    order_factory(status="empty")
     response = OrdersAdminApi(http_client=api_client).list()
     assert response.status_code == HTTP_200_OK
     assert response.json() == {
@@ -40,7 +42,9 @@ def test_admin_list_returns_only_orders_with_payment_history_and_products(api_cl
 
 
 @pytest.mark.django_db
-def test_admin_list_filters_by_status_csv(api_client, completed_order, refunded_order):
+def test_admin_list_filters_by_status_csv(api_client, order_factory):
+    order_factory(status="completed")
+    refunded_order = order_factory(status="refunded")
     response = OrdersAdminApi(http_client=api_client).list({"status": "refunded"})
     assert response.status_code == HTTP_200_OK
     assert response.json() == {
@@ -52,8 +56,8 @@ def test_admin_list_filters_by_status_csv(api_client, completed_order, refunded_
 
 
 @pytest.mark.django_db
-def test_admin_list_filters_by_product_id_distinct(api_client, completed_order, product):
-    # distinct=True 라 OPR 여러 개 매칭돼도 같은 order 한 번만 반환.
+def test_admin_list_filters_by_product_id_distinct(api_client, product, order_factory):
+    completed_order = order_factory(status="completed")
     response = OrdersAdminApi(http_client=api_client).list({"product_id": str(product.id)})
     assert response.status_code == HTTP_200_OK
     assert response.json() == {
@@ -65,16 +69,16 @@ def test_admin_list_filters_by_product_id_distinct(api_client, completed_order,
 
 
 @pytest.mark.django_db
-def test_admin_retrieve_returns_nested_payload(api_client, completed_order):
+def test_admin_retrieve_returns_nested_payload(api_client, order_factory):
+    completed_order = order_factory(status="completed")
     response = OrdersAdminApi(http_client=api_client).retrieve(completed_order.id)
     assert response.status_code == HTTP_200_OK
     assert response.json() == OrderAdminSerializer(instance=OrderAdminViewSet.queryset.get(id=completed_order.id)).data
 
 
 @pytest.mark.django_db
-def test_admin_refund_action_refunds_order_with_valid_totp(
-    api_client, completed_order, mock_portone_req_cancel_payment
-):
+def test_admin_refund_action_refunds_order_with_valid_totp(api_client, mock_portone_req_cancel_payment, order_factory):
+    completed_order = order_factory(status="completed")
     response = OrdersAdminApi(http_client=api_client).refund(completed_order.id, totp=valid_refund_totp())
     assert response.status_code == HTTP_204_NO_CONTENT
     completed_order.refresh_from_db()
@@ -84,23 +88,26 @@ def test_admin_refund_action_refunds_order_with_valid_totp(
 
 
 @pytest.mark.django_db
-def test_admin_refund_action_rejects_invalid_totp(api_client, completed_order, mock_portone_req_cancel_payment):
+def test_admin_refund_action_rejects_invalid_totp(api_client, mock_portone_req_cancel_payment, order_factory):
+    completed_order = order_factory(status="completed")
     response = OrdersAdminApi(http_client=api_client).refund(completed_order.id, totp="000000")
     assert response.status_code == HTTP_400_BAD_REQUEST
     mock_portone_req_cancel_payment.assert_not_called()
 
 
 @pytest.mark.django_db
-def test_admin_refund_action_rejects_missing_totp(api_client, completed_order, mock_portone_req_cancel_payment):
+def test_admin_refund_action_rejects_missing_totp(api_client, mock_portone_req_cancel_payment, order_factory):
+    completed_order = order_factory(status="completed")
     response = OrdersAdminApi(http_client=api_client).refund(completed_order.id)
     assert response.status_code == HTTP_400_BAD_REQUEST
     mock_portone_req_cancel_payment.assert_not_called()
 
 
 @pytest.mark.django_db
 def test_admin_refund_product_action_does_partial_refund(
-    api_client, completed_order, product, mock_portone_req_cancel_payment
+    api_client, product, mock_portone_req_cancel_payment, order_factory
 ):
+    completed_order = order_factory(status="completed")
     target_opr = completed_order.products.first()
     OrderProductRelation.objects.create(
         order=completed_order, product=product, price=product.price, status=OrderProductRelation.OrderProductStatus.paid
@@ -116,16 +123,17 @@ def test_admin_refund_product_action_does_partial_refund(
 
 
 @pytest.mark.django_db
-def test_admin_refund_product_action_returns_404_for_unknown_rel(api_client, completed_order):
+def test_admin_refund_product_action_returns_404_for_unknown_rel(api_client, order_factory):
+    completed_order = order_factory(status="completed")
     response = OrdersAdminApi(http_client=api_client).refund_product(
         completed_order.id, "00000000-0000-0000-0000-000000000000", totp=valid_refund_totp()
     )
     assert response.status_code == HTTP_404_NOT_FOUND
 
 
 @pytest.mark.django_db
-def test_admin_refund_allows_expired_window(api_client, completed_order, mock_portone_req_cancel_payment):
-    # admin endpoint 는 check_refundable_date=False 로 expired 상품도 환불 가능.
+def test_admin_refund_allows_expired_window(api_client, mock_portone_req_cancel_payment, order_factory):
+    completed_order = order_factory(status="completed")
     product = completed_order.products.first().product
     product.refundable_ends_at = datetime(2020, 1, 1, tzinfo=timezone.utc)
     product.save()
@@ -196,8 +204,9 @@ def test_admin_import_csv_returns_400_for_invalid_rows_without_persisting(api_cl
 @freeze_time(datetime(2026, 5, 23, 15, 30, 45, tzinfo=timezone.utc))
 @pytest.mark.django_db
 def test_admin_export_returns_xlsx_filtering_refunded_per_include_flag(
-    api_client, customer_user, refunded_order, product, include_refunded
+    api_client, customer_user, product, include_refunded, order_factory
 ):
+    refunded_order = order_factory(status="refunded")
     response = OrdersAdminApi(http_client=api_client).export(
         {"product_ids": [str(product.id)], "include_refunded": include_refunded}
     )
@@ -262,7 +271,8 @@ def test_admin_export_rejects_missing_or_empty_product_ids(api_client, payload):
 
 
 @pytest.mark.django_db
-def test_admin_partial_update_modifies_existing_customer_info(api_client, completed_order):
+def test_admin_partial_update_modifies_existing_customer_info(api_client, order_factory):
+    completed_order = order_factory(status="completed")
     response = OrdersAdminApi(http_client=api_client).update(
         completed_order.id,
         {"customer_info": {"name": "수정", "phone": "01099998888", "email": "new@x.com", "organization": "Z"}},
@@ -274,7 +284,8 @@ def test_admin_partial_update_modifies_existing_customer_info(api_client, comple
 
 
 @pytest.mark.django_db
-def test_admin_partial_update_creates_customer_info_when_missing(api_client, completed_order):
+def test_admin_partial_update_creates_customer_info_when_missing(api_client, order_factory):
+    completed_order = order_factory(status="completed")
     CustomerInfo.objects.filter(order=completed_order).hard_delete()
     response = OrdersAdminApi(http_client=api_client).update(
         completed_order.id,
@@ -285,7 +296,8 @@ def test_admin_partial_update_creates_customer_info_when_missing(api_client, com
 
 
 @pytest.mark.django_db
-def test_admin_list_filters_by_user_id(api_client, completed_order, customer_user, other_user, product):
+def test_admin_list_filters_by_user_id(api_client, customer_user, other_user, product, order_factory):
+    completed_order = order_factory(status="completed")
     other_order = Order.objects.create(user=other_user, name="other")
     OrderProductRelation.objects.create(
         order=other_order, product=product, price=product.price, status=OrderProductRelation.OrderProductStatus.paid