gh-144128: Address review feedback

Author: priyanshu2282-cyber

Lib/test/test_array.py

@@ -77,13 +77,14 @@ def __index__(self):
                 return "not an int"
 
         for typecode in ('I', 'L', 'Q'):
-            lst = []
-            e = Evil(lst)
-            lst.append(e)
-            del e
-            a = array.array(typecode)
-            with self.assertRaises(TypeError):
-                a.fromlist(lst)
+            with self.subTest(typecode=typecode):
+                lst = []
+                e = Evil(lst)
+                lst.append(e)
+                del e
+                a = array.array(typecode)
+                with self.assertRaises(TypeError):
+                    a.fromlist(lst)
 
 
 

Modules/arraymodule.c

@@ -410,7 +410,7 @@ II_setitem(arrayobject *ap, Py_ssize_t i, PyObject *v)
     if (!PyLong_Check(v)) {
         PyObject *orig_v = v;
         Py_INCREF(orig_v);
-        v = _PyNumber_Index(v);
+        v = _PyNumber_Index(orig_v);
         Py_DECREF(orig_v);
         if (NULL == v) {
             return -1;
@@ -473,7 +473,7 @@ LL_setitem(arrayobject *ap, Py_ssize_t i, PyObject *v)
     if (!PyLong_Check(v)) {
         PyObject *orig_v = v;
         Py_INCREF(orig_v);
-        v = _PyNumber_Index(v);
+        v = _PyNumber_Index(orig_v);
         Py_DECREF(orig_v);
         if (NULL == v) {
             return -1;
@@ -529,7 +529,7 @@ QQ_setitem(arrayobject *ap, Py_ssize_t i, PyObject *v)
     if (!PyLong_Check(v)) {
         PyObject *orig_v = v;
         Py_INCREF(orig_v);
-        v = _PyNumber_Index(v);
+        v = _PyNumber_Index(orig_v);
         Py_DECREF(orig_v);
         if (NULL == v) {
             return -1;