Fix UBSan error in _testcapi: correct create_attr_from_spec signature (#143097)

ashm-dev · sobolevn · web-flow · commit 7ca9e7ad053c · 2026-01-17T18:05:09.000Z
Co-authored-by: sobolevn &lt;mail@sobolevn.me&gt;
diff --git a/Modules/_testcapi/module.c b/Modules/_testcapi/module.c
@@ -178,7 +178,7 @@ module_from_slots_exec(PyObject *self, PyObject *spec)
 }
 
 static PyObject *
-create_attr_from_spec(PyObject *spec, PyObject *def)
+create_attr_from_spec(PyObject *spec, PyModuleDef *def)
 {
     assert(!def);
     return PyObject_GetAttrString(spec, "_gimme_this");

Original file line number	Diff line number	Diff line change
`@@ -178,7 +178,7 @@ module_from_slots_exec(PyObject self, PyObject spec)`
`178`	`178`	`}`
`179`	`179`
`180`	`180`	`static PyObject *`
`181`		`-create_attr_from_spec(PyObject spec, PyObject def)`
	`181`	`+create_attr_from_spec(PyObject spec, PyModuleDef def)`
`182`	`182`	`{`
`183`	`183`	`assert(!def);`
`184`	`184`	`return PyObject_GetAttrString(spec, "_gimme_this");`