Remove unreachable code in mmapmodule error path on Windows (GH-143063)

hyongtao-code · web-flow · commit 39608781437e · 2025-12-22T11:16:50.000+01:00
mmapmodule: remove unreachable code in Windows error path

Remove an unreachable `return NULL` after `PyErr_SetFromWindowsErr()` in
the Windows mmap resize error path.

Signed-off-by: Yongtao Huang &lt;yongtaoh2022@gmail.com&gt;
diff --git a/Modules/mmapmodule.c b/Modules/mmapmodule.c
@@ -963,7 +963,6 @@ mmap_mmap_resize_impl(mmap_object *self, Py_ssize_t new_size)
 
         if (error) {
             return PyErr_SetFromWindowsErr(error);
-            return NULL;
         }
         /* It's possible for a resize to fail, typically because another mapping
         is still held against the same underlying file. Even if nothing has

Original file line number	Diff line number	Diff line change
`@@ -963,7 +963,6 @@ mmap_mmap_resize_impl(mmap_object *self, Py_ssize_t new_size)`
`963`	`963`
`964`	`964`	`if (error) {`
`965`	`965`	`return PyErr_SetFromWindowsErr(error);`
`966`		`- return NULL;`
`967`	`966`	`}`
`968`	`967`	`/* It's possible for a resize to fail, typically because another mapping`
`969`	`968`	`is still held against the same underlying file. Even if nothing has`