gh-144307: Fix a reference leak during module teardown (GH-144308)

hyongtao-code · blurb-it[bot] · web-flow · commit 219b7ac9d562 · 2026-01-29T13:50:54.000-05:00
Signed-off-by: Yongtao Huang &lt;yongtaoh2022@gamil.com&gt;
Co-authored-by: blurb-it[bot] &lt;43283697+blurb-it[bot]@users.noreply.github.com&gt;
diff --git a/Misc/NEWS.d/next/Core_and_Builtins/2026-01-29-02-18-08.gh-issue-144307.CLbm_o.rst b/Misc/NEWS.d/next/Core_and_Builtins/2026-01-29-02-18-08.gh-issue-144307.CLbm_o.rst
@@ -0,0 +1 @@
+Prevent a reference leak in module teardown at interpreter finalization.
diff --git a/Python/pylifecycle.c b/Python/pylifecycle.c
@@ -1622,6 +1622,7 @@ finalize_remove_modules(PyObject *modules, int verbose)
                 PyObject *value = PyObject_GetItem(modules, key);
                 if (value == NULL) {
                     PyErr_FormatUnraisable("Exception ignored while removing modules");
+                    Py_DECREF(key);
                     continue;
                 }
                 CLEAR_MODULE(key, value);

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	`+Prevent a reference leak in module teardown at interpreter finalization.`
Original file line number	Diff line number	Diff line change
`@@ -1622,6 +1622,7 @@ finalize_remove_modules(PyObject *modules, int verbose)`
`1622`	`1622`	`PyObject *value = PyObject_GetItem(modules, key);`
`1623`	`1623`	`if (value == NULL) {`
`1624`	`1624`	`PyErr_FormatUnraisable("Exception ignored while removing modules");`
	`1625`	`+ Py_DECREF(key);`
`1625`	`1626`	`continue;`
`1626`	`1627`	`}`
`1627`	`1628`	`CLEAR_MODULE(key, value);`