Skip to content

Commit 9ee8150

Browse files
author
Tilman Krummeck
committed
Added changelog entry. Added annotation for deprecated signal QNetworkAccessManager.networkAccessibleChanged
1 parent b8e0a2b commit 9ee8150

File tree

2 files changed

+2
-1
lines changed

2 files changed

+2
-1
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).
1717
* [#51](https://github.com/stlehmann/PyQt5-stubs/pull/51) adds `pyqtBoundSignal.signal` hinted as `str`
1818

1919
### Changed
20+
* [#129](https://github.com/stlehmann/PyQt5-stubs/pull/129) fixes `QThread` and `QNetworkAccessManager` signals
2021
* [#109](https://github.com/stlehmann/PyQt5-stubs/pull/109) `.__or__()` for `QMessageBox.StandardButton` and `QMessageBox.StandardButtons`
2122
* [#126](https://github.com/stlehmann/PyQt5-stubs/pull/126) fix `QCoreApplication.instance()` return type to be optional
2223
* [#102](https://github.com/stlehmann/PyQt5-stubs/pull/102) fix `pyqtSlot` parameter typing and overloads

PyQt5-stubs/QtNetwork.pyi

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -765,7 +765,7 @@ class QNetworkAccessManager(QtCore.QObject):
765765
def proxyFactory(self) -> 'QNetworkProxyFactory': ...
766766
def createRequest(self, op: 'QNetworkAccessManager.Operation', request: 'QNetworkRequest', device: typing.Optional[QtCore.QIODevice] = ...) -> 'QNetworkReply': ...
767767
preSharedKeyAuthenticationRequired = typing.ClassVar[QtCore.pyqtSignal]
768-
def networkAccessibleChanged(self, accessible: 'QNetworkAccessManager.NetworkAccessibility') -> None: ...
768+
networkAccessibleChanged = typing.ClassVar[QtCore.pyqtSignal]
769769
sslErrors: typing.ClassVar[QtCore.pyqtSignal]
770770
encrypted: typing.ClassVar[QtCore.pyqtSignal]
771771
finished: typing.ClassVar[QtCore.pyqtSignal]

0 commit comments

Comments
 (0)