fix(argparse): prefer positional hint over flags when input is empty

Modified ArgparseCompleter to only fallback to flag completion when the current positional argument is full (reached its max nargs) instead of just reaching its minimum. This fixes an issue where commands with optional positional arguments (like 'history') would automatically complete '-' and show flags instead of the more useful positional hint text when tab-completed with no input.

Author: tleonhardt

cmd2/argparse_completer.py

@@ -458,7 +458,7 @@ def _handle_last_token(
                 elif (
                     not text
                     and not results
-                    and (isinstance(pos_arg_state.min, int) and pos_arg_state.count >= pos_arg_state.min)
+                    and (isinstance(pos_arg_state.max, int) and pos_arg_state.count >= pos_arg_state.max)
                 ):
                     flag_results = self._complete_flags(text, line, begidx, endidx, matched_flags)
                     if flag_results:

tests/test_argparse_completer.py

@@ -1086,8 +1086,8 @@ def test_arg_tokens(ac_app, command_and_args, completions) -> None:
 @pytest.mark.parametrize(
     ('command_and_args', 'text', 'output_contains', 'first_match'),
     [
-        # Group isn't done. Flags will complete and hint will be set but not printed by complete()
-        ('mutex', '', '', '--flag'),
+        # Group isn't done. The optional positional's hint will show and flags will not complete.
+        ('mutex', '', 'the optional positional', None),
         # Group isn't done. Flag name will still complete.
         ('mutex', '--fl', '', '--flag '),
         # Group isn't done. Flag hint will show.