Enable --max-failures. (#9)

Author: tobiasraabe

.conda/meta.yaml

@@ -21,7 +21,7 @@ requirements:
   run:
     - python >=3.6
     - cloudpickle
-    - pytask >=0.0.6
+    - pytask >=0.0.11
 
 test:
   requires:

CHANGES.rst

@@ -11,6 +11,7 @@ all releases are available on `Anaconda.org
 ------------------
 
 - :gh:`5` fixes the CI and other smaller issues.
+- :gh:`9` enables --max-failures. Closes :gh:`7`.
 
 
 0.0.4 - 2020-10-30

environment.yml

@@ -12,7 +12,7 @@ dependencies:
   - conda-verify
 
   # Package dependencies
-  - pytask >= 0.0.6
+  - pytask >= 0.0.11
   - cloudpickle
   - loky
 

src/pytask_parallel/execute.py

@@ -49,7 +49,7 @@ def pytask_execute_build(session):
 
     """
     if session.config["n_workers"] > 1:
-        reports = []
+        reports = session.execution_reports
         running_tasks = {}
 
         parallel_backend = PARALLEL_BACKENDS[session.config["parallel_backend"]]
@@ -123,9 +123,12 @@ def pytask_execute_build(session):
                     )
                     reports.append(report)
 
-                time.sleep(session.config["delay"])
+                if session.should_stop:
+                    break
+                else:
+                    time.sleep(session.config["delay"])
 
-        return reports
+        return True
 
 
 class ProcessesNameSpace:

tests/test_execute.py

@@ -163,3 +163,28 @@ def task_2(produces):
     )
 
     assert 3 < session.execution_end - session.execution_start < 10
+
+
+@pytest.mark.end_to_end
+@pytest.mark.parametrize("parallel_backend", PARALLEL_BACKENDS)
+def test_stop_execution_when_max_failures_is_reached(tmp_path, parallel_backend):
+    source = """
+    import time
+
+    def task_3(): raise NotImplmentedError
+    def task_2(): time.sleep(2); raise NotImplementedError
+    def task_1(): pass
+    """
+    tmp_path.joinpath("task_dummy.py").write_text(textwrap.dedent(source))
+
+    session = main(
+        {
+            "paths": tmp_path,
+            "n_workers": 2,
+            "parallel_backend": parallel_backend,
+            "max_failures": 1,
+        }
+    )
+
+    assert len(session.tasks) == 3
+    assert len(session.execution_reports) == 2

tox.ini

@@ -10,7 +10,7 @@ basepython = python
 conda_deps =
     cloudpickle
     loky
-    pytask >=0.0.6
+    pytask >=0.0.11
     pytest
     pytest-cov
     pytest-xdist