You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Added a "Save for Later / Bookmark" feature allowing students to easily save topics and access them via a dedicated Bookmarks page. This heavily improves UX by preventing students from having to manually navigate deep into semester folders to find their current reading position.
Changes made:
Created useBookmarks.ts custom hook utilizing localStorage for state persistence.
Built a reusable BookmarkButton.tsx component.
Created a /bookmarks page to display and manage saved topics.
Added a BOOKMARKS link to both desktop and mobile Navbars.
Integrated the BookmarkButton into the DSC subject pages (and others).
Type of Change
Bug fix
New feature
Documentation update
UI/UX improvement
Refactor
Screenshots / Demo
Before - Bookmarks tab And No save option
After - Added Bookmark tab and Save option To continue reading
How Has This Been Tested?
Tested locally using npm run dev.
Verified that localStorage persists data across page reloads and browser restarts.
Tested responsive design on the Bookmarks page and Mobile Navbar.
Checklist
My code follows the project structure and conventions
A few more things to improve here before this can be merged:
The /bookmarks page currently feels disconnected from the rest of the app. Please add the common navbar/footer layout there as well so it stays visually consistent with the project.
The bookmark button and its placement also feels slightly off right now and breaks the visual flow of the page. Try positioning it more cleanly near the navigation actions/header area instead (similar to the attached reference).
Please also clean up unrelated/noisy changes in this PR (duplicate JSX/imports, repeated blocks, unnecessary formatting changes, etc.) to keep the review focused only on the bookmark feature.
issues.json also seems unrelated to this feature and should not be committed.
Hi @pushkarscripts,
I've successfully resolved the merge conflicts that occurred due to the recent Quiz updates.
I made sure to cleanly combine both the new ChapterQuizInline imports and my BookmarkButton imports so everything functions perfectly together.
The PR is now fully up to date with the latest main branch and ready for your review whenever you have the time! Let me know if you need any other changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
Fixes #89
Description
Added a "Save for Later / Bookmark" feature allowing students to easily save topics and access them via a dedicated Bookmarks page. This heavily improves UX by preventing students from having to manually navigate deep into semester folders to find their current reading position.
Changes made:
useBookmarks.tscustom hook utilizinglocalStoragefor state persistence.BookmarkButton.tsxcomponent./bookmarkspage to display and manage saved topics.BOOKMARKSlink to both desktop and mobile Navbars.BookmarkButtoninto the DSC subject pages (and others).Type of Change
Screenshots / Demo
Before - Bookmarks tab And No save option

After - Added Bookmark tab and Save option To continue reading


How Has This Been Tested?
npm run dev.localStoragepersists data across page reloads and browser restarts.Checklist