Misformatted changelog on "Update Changelog" PR

[pedro-psb]

A recent "Update Changelog" PR on pulpcore added a malformed title which broke the changelog ToC page.
See here: pulp/pulpcore@8afdd1a#r145350978

I didn't look into it yet, but maybe it's something that needs adjusting in the collect_changes script.

Screenshot

[pedro-psb]

AFAIK this appeared originally on 3.57 branch release (pulp/pulpcore@a5c9aec), which is generated by https://github.com/pulp/pulpcore/blob/main/.github/workflows/scripts/release.sh.

By going back to the 3.57.0 release parent commit and running the release.sh commands (basically towncrier) I wasnt able to reproduce it.

[mdellweg]

Sounds like we should just observe if this ever happens again...

[pedro-psb]

@mdellweg had this idea we can investigate:

The use of ## (h2) and #### (h4) without ### (h3) is because we use that level for the plugin api heading, right? Do you think that may be related to what we see here?
We probably don't strictly have the same format on all old branches and somwhere a regex for "## " matches part of "### " and boom there we are.

pulp/pulp_ansible#2012 (comment)

[pedro-psb]

@mdellweg did that work? pulp/pulp_ansible@79fe155

I'm thinking the problem may not be in collect_changes, because it happened on a release workflow, which only calls towncrier build.
pulp/pulpcore@a5c9aec

[mdellweg]

It fixed at least one issue there...